Bug 2236421

Summary: Review Request: libmks - Mouse, Keyboard and screen for QEMU DBus UI backend
Product: [Fedora] Fedora Reporter: bilelmoussaoui <belmouss>
Component: Package ReviewAssignee: Sandro Bonazzola <sbonazzo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: sbonazzo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: libmks-0.1.3-2.fc40 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-09-11 09:01:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description bilelmoussaoui 2023-08-31 08:41:44 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/@centos-automotive-sig/dui/fedora-39-x86_64/06384511-libmks/libmks.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/@centos-automotive-sig/dui/fedora-39-x86_64/06384511-libmks/libmks-0.1.3-1.fc39.src.rpm
Description: libmks is a library for interacting with the QEMU DBus UI backend built with GTK 4 support. It supports Mouse, Keyboard and multi touch events. The clipboard / usb redirection features are still missing but it is much better then spice in terms of rendering.
Fedora Account System Username: bilelmoussaoui

The libmks package was already tested in https://copr.fedorainfracloud.org/coprs/g/centos-automotive-sig/dui/ for a while.

This is my first package so I would need sponsorship for it.
Comment 1 Sandro Bonazzola 2023-08-31 09:46:06 UTC 
Putting the review on hold, working with @belmouss to get it ready.
Comment 2 bilelmoussaoui 2023-09-01 07:15:41 UTC 
the package should be ready for a review now
Comment 3 Sandro Bonazzola 2023-09-01 07:18:13 UTC 
thanks, I'm on it.
Comment 4 Sandro Bonazzola 2023-09-01 08:29:53 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU Lesser General Public License,
     Version 2.1", "GNU Lesser General Public License v2.1 or later", "GNU
     Lesser General Public License, Version 2.1 GNU General Public License
     v3.0 or later". 23 files have unknown license.
     There are SPDX tags not matching license notices so LGPL-2.1-or-later
     may be correct if the upstream sources get fixed.
     Reported upstream: https://gitlab.gnome.org/GNOME/libmks/-/issues/11
[!]: License file installed when any subpackage combination is installed.
     The doc subpackage only suggests devel subpackage so it may be
     installed without an installed license file
[!]: Package does not own files or directories owned by other packages.
     Notes:
     As /usr/share/gir-1.0 is already owned by gtk4-devel and -devel subpackage already
     requires pkgconfig(gtk4),
     I would remove the ownership of /usr/share/gir-1.0 from this package.
     /usr/lib64/girepository-1.0 is already owned by gtk4 which is already required.
     I would remove the ownership of that directory from the package.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 2263 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
     This is missing but unit testing of upstream sources is very limited.
     Not worth to run it.
[-]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: libmks-0.1.2-1.fc40.x86_64.rpm
          libmks-devel-0.1.2-1.fc40.x86_64.rpm
          libmks-doc-0.1.2-1.fc40.noarch.rpm
          libmks-debuginfo-0.1.2-1.fc40.x86_64.rpm
          libmks-debugsource-0.1.2-1.fc40.x86_64.rpm
          libmks-0.1.2-1.fc40.src.rpm
=========================================================================== rpmlint session starts ==========================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpouoo1kwq')]
checks: 31, packages: 6

libmks.x86_64: W: no-manual-page-for-binary mks
libmks.x86_64: W: no-manual-page-for-binary mks-connect
libmks.spec:7: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 7)
============================================ 6 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.4 s ===========================================




Rpmlint (debuginfo)
-------------------
Checking: libmks-debuginfo-0.1.2-1.fc40.x86_64.rpm
=========================================================================== rpmlint session starts ==========================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpg84kyodp')]
checks: 31, packages: 1

============================================ 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s ===========================================





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 5

libmks.x86_64: W: no-manual-page-for-binary mks
libmks.x86_64: W: no-manual-page-for-binary mks-connect
 5 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.9 s 



Source checksums
----------------
https://download.gnome.org/sources/libmks/0.1/libmks-0.1.2.tar.xz :
  CHECKSUM(SHA256) this package     : c2d117970e3eb31bf6ad8df059739e74f930234bd293e12761916f0463d868c7
  CHECKSUM(SHA256) upstream package : c2d117970e3eb31bf6ad8df059739e74f930234bd293e12761916f0463d868c7


Requires
--------
libmks (rpmlib, GLIBC filtered):
    glib2(x86-64)
    gtk4(x86-64)
    libc.so.6()(64bit)
    libcairo-gobject.so.2()(64bit)
    libcairo.so.2()(64bit)
    libepoxy.so.0()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-4.so.1()(64bit)
    libmks-1.so.0()(64bit)
    qemu-ui-dbus
    qemu-ui-opengl
    rtld(GNU_HASH)

libmks-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libmks(x86-64)
    libmks-1.so.0()(64bit)
    pkgconfig(gio-2.0)
    pkgconfig(gio-unix-2.0)
    pkgconfig(gtk4)

libmks-doc (rpmlib, GLIBC filtered):

libmks-debuginfo (rpmlib, GLIBC filtered):

libmks-debugsource (rpmlib, GLIBC filtered):



Provides
--------
libmks:
    libmks
    libmks(x86-64)
    libmks-1.so.0()(64bit)

libmks-devel:
    libmks-devel
    libmks-devel(x86-64)
    pkgconfig(libmks-1)

libmks-doc:
    libmks-doc

libmks-debuginfo:
    debuginfo(build-id)
    libmks-1.so.0.1.2-0.1.2-1.fc40.x86_64.debug()(64bit)
    libmks-debuginfo
    libmks-debuginfo(x86-64)

libmks-debugsource:
    libmks-debugsource
    libmks-debugsource(x86-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2236421
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, C/C++
Disabled plugins: Ruby, Python, Haskell, Perl, R, Java, SugarActivity, PHP, Ocaml, fonts
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Comment 5 bilelmoussaoui 2023-09-01 08:39:51 UTC 
> License field in the package spec file matches the actual license.

Aha,  I will get that fixed upstream.

> License file installed when any subpackage combination is installed.
> Package does not own files or directories owned by other packages.


I have followed what is used in other gtk4 based libraries like libpanel/libadwaita for these two. Not sure if we want to diverge here.
Comment 6 bilelmoussaoui 2023-09-08 07:46:52 UTC 
I have created a new release with the license fixes and updated the spec/SRPM links in the issue description with updated ones.
Comment 7 Sandro Bonazzola 2023-09-08 07:54:26 UTC 
(In reply to bilelmoussaoui from comment #6)
> I have created a new release with the license fixes and updated the
> spec/SRPM links in the issue description with updated ones.

Ok, starting another round of review :-)
Comment 8 Sandro Bonazzola 2023-09-08 08:48:29 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU Lesser General Public License,
     Version 2.1", "GNU Lesser General Public License v2.1 or later".
[x]: License file installed when any subpackage combination is installed.
     The doc subpackage only suggests devel subpackage so it may be
     installed without an installed license file. Considering it as ok
     because it gets installed by default.
[x]: Package does not own files or directories owned by other packages.
     Here the package behaves like similar others so 
     Note: Dirs in package are owned also by:
     /usr/lib64/girepository-1.0(libchamplain, gstreamer1-rtsp-server,
     gcr3, libgnome-keyring, gssdp, libgnomekbd, gplugin-gtk4-libs, gupnp-
     dlna, gnome-bluetooth-libs, libtracker-sparql, amtk, clutter,
     webkitgtk6.0, librsvg2, goocanvas2, appstream, template-glib, glade-
     libs, libgdl, gnome-autoar, libjcat, ibus-libs, libpanel, libdazzle,
     geoclue2-libs, gsequencer, gnome-calculator, libsoup3, libmodulemd1,
     libhandy, parquet-glib-libs, libarrow-glib-libs, accountsservice-libs,
     gupnp, gtk3, gnome-menus, graphene, libshumate, libgdata, libxmlb,
     libarrow-flight-libs, libarrow-dataset-glib-libs, libmypaint, jsonrpc-
     glib, babl, gst-devtools, libgedit-gtksourceview,
     javascriptcoregtk4.0, libsoup, javascriptcoregtk4.1, gnome-online-
     accounts, gcr-libs, libproxy, libgtop2, ghex-libs, gtksourceview5,
     malcontent-ui-libs, libmash, libinsane-gobject, webkit2gtk4.1,
     libgee06, grilo, libxklavier, GConf2, gsound, gtksourceview4, gmime30,
     vte, gitg-libs, javascriptcoregtk6.0, gnome-bluetooth3.34-libs,
     gspell, libgee, gplugin-libs, harfbuzz, gdk-pixbuf2, vips,
     webkit2gtk4.0, json-glib, zbar-gtk, atk, gucharmap-libs, gtk2,
     malcontent-libs, fcitx-libs, libdex, rygel, libsecret, at-spi2-core,
     gupnp-igd, libmanette, gtk4, playerctl-libs, libpeas, gupnp-av, tepl,
     gobject-introspection, libgexiv2, libdmapsharing4, libgepub, libgxps,
     vte291, libmodulemd, libcryptui),
     /usr/share/gir-1.0(libmodulemd1-devel, webkit2gtk4.0-devel, gsound-
     devel, libinsane-gobject-devel, ghex-devel, template-glib-devel,
     libsoup3-devel, gupnp-av-devel, gstreamer1-rtsp-server-devel, ibus-
     devel, clutter-devel, libgnomekbd-devel, colord-gtk-devel, tepl-devel,
     libhandy-devel, GConf2-devel, libcryptui-devel, libxklavier-devel,
     gcr3-devel, libpanel-devel, at-spi2-core-devel, libarrow-dataset-glib-
     devel, gcr-devel, gspell-devel, vips-devel, libsoup-devel,
     libmodulemd-devel, libmypaint-devel, jsonrpc-glib-devel, libadwaita-
     devel, gupnp-igd-devel, gupnp-dlna-devel, libgepub-devel,
     libgexiv2-devel, babl-devel, gtk2-devel, libgtop2-devel, totem-pl-
     parser-devel, tracker-devel, gitg-devel, gupnp-devel, libjcat-devel,
     libdex-devel, libgdata-devel, gtksourceview5-devel, gnome-
     bluetooth3.34-libs-devel, grilo-devel, json-glib-devel, vte291-devel,
     gst-devtools-devel, libgdl-devel, geoclue2-devel, libshumate-devel,
     libgee06-devel, libmanette-devel, zbar-gtk-devel, libxmlb-devel,
     rygel-devel, clapper-devel, gnome-calculator-devel, gnome-online-
     accounts-devel, webkitgtk6.0-devel, malcontent-ui-devel, gtk3-devel,
     gnome-autoar-devel, gsequencer-devel, libgxps-devel, libchamplain-
     devel, bamf-devel, accountsservice-devel, gucharmap-devel, gtk4-devel,
     gobject-introspection-devel, atk-devel, libpeas-devel, libmash-devel,
     libgee-devel, gnome-bluetooth-libs-devel, libgnome-keyring-devel,
     libsecret-devel, fcitx5-gtk-devel, amtk-devel, libgedit-gtksourceview-
     devel, fcitx-devel, goocanvas2-devel, libdmapsharing4-devel, libproxy-
     devel, webkit2gtk4.1-devel, gnome-menus-devel, parquet-glib-devel,
     gmime30-devel, harfbuzz-devel, gdk-pixbuf2-devel, librsvg2-devel,
     javascriptcoregtk6.0-devel, javascriptcoregtk4.0-devel, gplugin-devel,
     gssdp-devel, gtksourceview4-devel, libarrow-glib-devel, glade-devel,
     gplugin-gtk4-devel, javascriptcoregtk4.1-devel, malcontent-devel,
     libdazzle-devel, appstream-devel, gdm-devel, graphene-devel, budgie-
     desktop-devel, vte-devel, gegl04-devel), /usr/share/vala(rygel-devel,
     jsonrpc-glib-devel, gnome-calculator-devel, gsound-devel, libgda5-ui-
     devel, zeitgeist-devel, gtksourceview3-devel, template-glib-devel,
     pulseaudio-libs-devel, libcanberra-devel, pqmarble-devel, libtranslit-
     devel, gupnp-dlna-devel, gplugin-vala, libgexiv2-devel, gnome-online-
     accounts-devel, dconf-devel, gmime30-devel, libgda5-devel,
     libsoup3-devel, gupnp-av-devel, caribou-devel, gnome-autoar-devel,
     babl-devel, libosinfo-devel, librsvg2-devel, vala, ibus-devel,
     tracker-devel, gitg-devel, libgda-ui-devel, bamf-devel,
     accountsservice-devel, gupnp-devel, libgweather4-devel, libjcat-devel,
     libspelling-devel, gssdp-devel, gtksourceview4-devel, libgee-devel,
     libdex-devel, libgnome-keyring-devel, libhandy-devel, libsecret-devel,
     libdmapsharing4-devel, libdazzle-devel, gmime-devel, appstream-devel,
     gtksourceview5-devel, libgdata-devel, folks-devel, grilo-devel,
     libgit2-glib-devel, gcr3-devel, libgda-devel, vte291-devel, libpanel-
     devel, libgnome-games-support-devel, budgie-desktop-devel, libshumate-
     devel, gcr-devel, geoclue2-devel, gspell-devel, libgee06-devel,
     libmanette-devel, rhythmbox-devel, gegl04-devel, libsoup-devel,
     libgnome-games-support1-devel), /usr/share/vala/vapi(rygel-devel,
     jsonrpc-glib-devel, gnome-calculator-devel, gsound-devel, libgda5-ui-
     devel, zeitgeist-devel, gtksourceview3-devel, template-glib-devel,
     pulseaudio-libs-devel, libcanberra-devel, pqmarble-devel, libtranslit-
     devel, gupnp-dlna-devel, gplugin-vala, libgexiv2-devel, gnome-online-
     accounts-devel, dconf-devel, gmime30-devel, libgda5-devel,
     libsoup3-devel, gupnp-av-devel, caribou-devel, gnome-autoar-devel,
     babl-devel, libosinfo-devel, librsvg2-devel, vala, ibus-devel,
     tracker-devel, gitg-devel, libgda-ui-devel, bamf-devel,
     accountsservice-devel, gupnp-devel, libgweather4-devel, libjcat-devel,
     libspelling-devel, gssdp-devel, gtksourceview4-devel, fwupd-devel,
     libzeitgeist-devel, libgee-devel, libdex-devel, libgnome-keyring-
     devel, libhandy-devel, libsecret-devel, libdmapsharing4-devel,
     libdazzle-devel, libproxy-devel, gmime-devel, appstream-devel,
     gtksourceview5-devel, libgdata-devel, folks-devel, grilo-devel,
     libgit2-glib-devel, gcr3-devel, libgda-devel, vte291-devel, libpanel-
     devel, libgnome-games-support-devel, budgie-desktop-devel, libshumate-
     devel, gcr-devel, geoclue2-devel, gspell-devel, libgee06-devel,
     libmanette-devel, rhythmbox-devel, gegl04-devel, libsoup-devel,
     libgnome-games-support1-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 2397 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
     This is missing but unit testing of upstream sources is very limited.
     Not worth to run it.
[-]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: libmks-0.1.3-1.fc40.x86_64.rpm
          libmks-devel-0.1.3-1.fc40.x86_64.rpm
          libmks-doc-0.1.3-1.fc40.noarch.rpm
          libmks-debuginfo-0.1.3-1.fc40.x86_64.rpm
          libmks-debugsource-0.1.3-1.fc40.x86_64.rpm
          libmks-0.1.3-1.fc40.src.rpm
=========================================================================== rpmlint session starts ==========================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpce3bfy6p')]
checks: 31, packages: 6

libmks.x86_64: W: no-manual-page-for-binary mks
libmks.x86_64: W: no-manual-page-for-binary mks-connect
libmks.spec:7: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 7)
============================================ 6 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.5 s ===========================================




Rpmlint (debuginfo)
-------------------
Checking: libmks-debuginfo-0.1.3-1.fc40.x86_64.rpm
=========================================================================== rpmlint session starts ==========================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpk7bgfkx3')]
checks: 31, packages: 1

============================================ 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s ===========================================





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 5

libmks.x86_64: W: no-manual-page-for-binary mks
libmks.x86_64: W: no-manual-page-for-binary mks-connect
 5 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.8 s 



Source checksums
----------------
https://download.gnome.org/sources/libmks/0.1/libmks-0.1.3.tar.xz :
  CHECKSUM(SHA256) this package     : 4821c1d00915f2faf1fc431400ea9fb629322aac690d580904d634e339fa554c
  CHECKSUM(SHA256) upstream package : 4821c1d00915f2faf1fc431400ea9fb629322aac690d580904d634e339fa554c


Requires
--------
libmks (rpmlib, GLIBC filtered):
    glib2(x86-64)
    gtk4(x86-64)
    libc.so.6()(64bit)
    libcairo-gobject.so.2()(64bit)
    libcairo.so.2()(64bit)
    libepoxy.so.0()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-4.so.1()(64bit)
    libmks-1.so.0()(64bit)
    qemu-ui-dbus
    qemu-ui-opengl
    rtld(GNU_HASH)

libmks-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libmks(x86-64)
    libmks-1.so.0()(64bit)
    pkgconfig(gio-2.0)
    pkgconfig(gio-unix-2.0)
    pkgconfig(gtk4)

libmks-doc (rpmlib, GLIBC filtered):

libmks-debuginfo (rpmlib, GLIBC filtered):

libmks-debugsource (rpmlib, GLIBC filtered):



Provides
--------
libmks:
    libmks
    libmks(x86-64)
    libmks-1.so.0()(64bit)

libmks-devel:
    libmks-devel
    libmks-devel(x86-64)
    pkgconfig(libmks-1)

libmks-doc:
    libmks-doc

libmks-debuginfo:
    debuginfo(build-id)
    libmks-1.so.0.1.3-0.1.3-1.fc40.x86_64.debug()(64bit)
    libmks-debuginfo
    libmks-debuginfo(x86-64)

libmks-debugsource:
    libmks-debugsource
    libmks-debugsource(x86-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2236421
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: R, fonts, Python, Ruby, Perl, PHP, Ocaml, Haskell, SugarActivity, Java
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Comment 9 Fedora Review Service 2023-09-08 08:49:01 UTC 
Hello @bilelmoussaoui,
since this is your first Fedora package, you need to get sponsored by a package
sponsor before it can be accepted.

A sponsor is an experienced package maintainer who will guide you through
the processes that you will follow and the tools that you will use as a future
maintainer. A sponsor will also be there to answer your questions related to
packaging.

You can find all active sponsors here:
https://docs.pagure.org/fedora-sponsors/

I created a sponsorship request for you:
https://pagure.io/packager-sponsors/issue/590
Please take a look and make sure the information is correct.

Thank you, and best of luck on your packaging journey.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service
Comment 10 Neal Gompa 2023-09-08 12:54:02 UTC 
I've sponsored you as a packager. Congratulations and welcome to Fedora!
Comment 11 Fedora Admin user for bugzilla script actions 2023-09-08 14:17:08 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/libmks
Comment 12 Sandro Bonazzola 2023-09-11 09:01:35 UTC 
libmks-0.1.3-2.fc40 shipped to Rawhide via https://bodhi.fedoraproject.org/updates/FEDORA-2023-759490ff7d