Bug 2236496

Summary:	Do not install "disable" preset for fwupd-refresh.* units & follow presets
Product:	[Fedora] Fedora	Reporter:	Timothée Ravier <travier>
Component:	fwupd	Assignee:	Timothée Ravier <travier>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	39	CC:	awilliam, kparal, rhughes
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:	https://pagure.io/fedora-qa/blocker-review/issue/1244 AcceptedFreezeException
Fixed In Version:	fwupd-1.9.5-1.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-09-15 18:48:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2143445, 2233233

Description Timothée Ravier 2023-08-31 12:33:01 UTC

For https://fedoraproject.org/wiki/Changes/EnableFwupdRefreshByDefault, we need fwupd to follow the preset as set by the fedora-release package in https://src.fedoraproject.org/rpms/fedora-release/pull-request/279.

This has been submitted and fixed upstream with:
- https://github.com/fwupd/fwupd/issues/6115
- https://github.com/fwupd/fwupd/pull/6116

Backport PR in https://src.fedoraproject.org/rpms/fwupd/pull-request/9

Reproducible: Always

Comment 1 Fedora Blocker Bugs Application 2023-08-31 12:34:31 UTC

Proposed as a Freeze Exception for 39-beta by Fedora user siosm using the blocker tracking app because:

 This is a relatively small change to complete the following accepted change request: https://fedoraproject.org/wiki/Changes/EnableFwupdRefreshByDefault

The change was accepted late by FESCo which lead to us landing the change too late.

Comment 2 Kamil Páral 2023-09-01 08:34:12 UTC

FE discussion ticket: https://pagure.io/fedora-qa/blocker-review/issue/1244

Comment 3 Adam Williamson 2023-09-03 17:01:16 UTC

+3 in https://pagure.io/fedora-qa/blocker-review/issue/1244 , marking accepted.

Comment 4 Timothée Ravier 2023-09-04 14:48:11 UTC

This landed in rawhide and f39 via an update to latest upstream release which has the fix.

This is now in https://bodhi.fedoraproject.org/updates/FEDORA-2023-3a993e4ded

Comment 5 Fedora Update System 2023-09-04 14:49:21 UTC

FEDORA-2023-3a993e4ded has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3a993e4ded

Comment 6 Timothée Ravier 2023-09-04 14:51:30 UTC

I've added this bug to the update but I'm not sure how to have it unblocked now that the BetaFE has been granted.

Comment 7 Adam Williamson 2023-09-04 15:04:27 UTC

You don't do that, I do.

But, I do have a question. Aren't this and https://bugzilla.redhat.com/show_bug.cgi?id=2236498 related? Shouldn't there be a corresponding update for fedora-release? Is it safe to push the fwupd update without a fedora-release update?

Comment 8 Fedora Update System 2023-09-05 02:00:54 UTC

FEDORA-2023-3a993e4ded has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-3a993e4ded`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-3a993e4ded

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Timothée Ravier 2023-09-08 10:36:39 UTC

With the preset change, this update is a nope as it removes a preset file that disables those units and those are already disabled by default in Fedora.

We need both PR / updates for the change but this update can land first.

Comment 10 Fedora Update System 2023-09-15 18:48:24 UTC

FEDORA-2023-3a993e4ded has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.