Bug 2236502

Summary:	Product without any repo is added to a Sync Plan regardless the error message
Product:	Red Hat Satellite	Reporter:	Vladimír Sedmík <vsedmik>
Component:	Sync Plans	Assignee:	Samir Jha <sajha>
Status:	CLOSED ERRATA	QA Contact:	Vladimír Sedmík <vsedmik>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	6.14.0	CC:	rlavi, sajha
Target Milestone:	6.15.0	Keywords:	Regression, Triaged
Target Release:	Unused
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-04-23 17:14:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vladimír Sedmík 2023-08-31 13:27:11 UTC

Description of problem:
Since 6.14 an error message is shown when you try to add a Product with no repos to a Sync Plan, but the product is added regardless the message.


Version-Release number of selected component (if applicable):
6.14.0 snap 14


How reproducible:
always


Steps to Reproduce:
1. Create a custom Product without any repo.
2. Create a Sync Plan.
3. Add the Product to the Sync Plan.


Actual results:
Error message "Cannot add product <prod> because it is disabled." is shown, but the product is added anyway.


Expected results:
Product is not added.

Comment 3 Samir Jha 2023-09-12 19:31:19 UTC

Created redmine issue https://projects.theforeman.org/issues/36739 from this bug

Comment 4 Bryan Kearney 2023-09-16 00:02:54 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/36739 has been resolved.

Comment 5 Brad Buckingham 2023-10-30 11:29:29 UTC

Bulk setting Target Milestone = 6.15.0 where sat-6.15.0+ is set.

Comment 6 Vladimír Sedmík 2023-11-02 09:40:48 UTC

Verified in 6.15.0 (stream snap 34):

1. Empty custom product can be added but no error message is shown in UI (same behaviour as previous 6.13).

2. Custom product with custom repos can be added just fine.

3. Disabled RH product can't be added, proper error message is shown:
[root@satellite ~]# hammer product set-sync-plan --id 777 --sync-plan-id 3
Could not assign synchronization plan:
  Validation failed: Cannot add disabled Red Hat product Red Hat Virtualization Manager to sync plan!

4. Enabled RH product can be added just fine:
[root@satellite ~]# hammer product set-sync-plan --id 616 --sync-plan-id 3
Synchronization plan assigned.

Note:
The time issue from comment#1 and comment#2 will be tracked by https://bugzilla.redhat.com/show_bug.cgi?id=2241944

Comment 9 errata-xmlrpc 2024-04-23 17:14:16 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.15.0 release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:2010