Bug 2236870

Summary: Review Request: rust-gix-ignore - Gix implemenation for handling git gitignore files
Product: [Fedora] Fedora Reporter: blinxen <h-k-81>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-09-17 18:44:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description blinxen 2023-09-01 20:18:29 UTC
Spec URL: https://blinxen.fedorapeople.org/rust-gix-ignore/rust-gix-ignore.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-gix-ignore/rust-gix-ignore-0.5.1-1.fc40.src.rpm

Description:
Gix implemenation for handling git gitignore files.

Fedora Account System Username: blinxen

Comment 1 blinxen 2023-09-01 20:18:32 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=105629650

Comment 2 Fabio Valentini 2023-09-09 12:28:12 UTC
Need to drop the document-features optional dependency (or package it).

Comment 3 blinxen 2023-09-15 18:38:19 UTC
Updated to the latest version

Links to the updated files:
Spec URL: https://blinxen.fedorapeople.org/rust-gix-ignore/rust-gix-ignore.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-gix-ignore/rust-gix-ignore-0.7.0-1.fc40.src.rpm

Comment 4 Fabio Valentini 2023-09-17 12:49:27 UTC
Thanks, looks good to me.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Fedora Admin user for bugzilla script actions 2023-09-17 18:11:07 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix-ignore

Comment 6 Fedora Update System 2023-09-17 18:41:39 UTC
FEDORA-2023-567d2109a9 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-567d2109a9

Comment 7 Fedora Update System 2023-09-17 18:44:07 UTC
FEDORA-2023-567d2109a9 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.