Bug 2236889

Summary:	asfdemux inclusion request - patent has expired
Product:	[Fedora] Fedora	Reporter:	Brendan Shanks <bshanks>
Component:	gstreamer1-plugins-ugly-free	Assignee:	Yaakov Selkowitz <yselkowi>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	ngompa13, wtaymans, yselkowi
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	gstreamer1-plugins-ugly-free-1.22.8-2.fc40 gstreamer1-plugins-ugly-free-1.22.8-2.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-12-21 00:00:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Brendan Shanks 2023-09-01 21:30:06 UTC

In bug 1397261 it was decided that asfdemux could not be included in gstreamer1-plugins-ugly-free, presumably because of a still-active US patent (https://patents.google.com/patent/US6041345A/) covering parts of the ASF format.

That was in 2016, since then the patent has expired. Is there a reason to continue excluding asfdemux from the package?

Reproducible: Always

Comment 1 Yaakov Selkowitz 2023-09-01 21:44:59 UTC

Tagging for Legal review.  The plugins still stripped from -ugly-free are as follows; can any of these now be included?

* asfdemux: demuxer for Microsoft's Advanced Streaming Format
* dvdlpcmdec: Decode DVD LPCM frames into standard PCM
* dvdsub: DVD subtitle parser and decoder
* realmedia: RealMedia support

Comment 2 Neal Gompa 2023-09-01 21:58:25 UTC

None of those appear to be problematic. We have these in other places in the distribution already.

The RealMedia support is just a demuxer rather than actually a codec, so there's nothing really to worry about here. There are old RA and RV codecs that are now shipped in Fedora that being able to demux an RM container or RM stream would be useful for (though in 2023, I don't know of any that still exist other than really old archives of stuff...).

I think at this point we can stop stripping things.

The only thing in -ugly we cannot *build* (but we don't have to strip) is the x264 plugin.

Comment 3 Neal Gompa 2023-09-01 21:59:24 UTC

Dropping the FE-Legal as it's not needed based on previous efforts.

Comment 4 Yaakov Selkowitz 2023-12-14 02:11:06 UTC

While we are at it, can we get an official decision on the plugins still being stripped from -bad-free as well, namely:

* dvbsuboverlay: DVB Subtitles Overlay
* dvdspu: DVD Sub-picture Overlay element
* siren: Siren encoder/decoder/payloader/depayloader plugins

Comment 5 Neal Gompa 2023-12-14 03:03:19 UTC

(In reply to Yaakov Selkowitz from comment #4)
> While we are at it, can we get an official decision on the plugins still
> being stripped from -bad-free as well, namely:
> 
> * dvbsuboverlay: DVB Subtitles Overlay
> * dvdspu: DVD Sub-picture Overlay element
> * siren: Siren encoder/decoder/payloader/depayloader plugins

These are all fine now too.

Comment 6 Neal Gompa 2023-12-14 03:06:10 UTC

(In reply to Neal Gompa from comment #5)
> (In reply to Yaakov Selkowitz from comment #4)
> > While we are at it, can we get an official decision on the plugins still
> > being stripped from -bad-free as well, namely:
> > 
> > * dvbsuboverlay: DVB Subtitles Overlay
> > * dvdspu: DVD Sub-picture Overlay element
> > * siren: Siren encoder/decoder/payloader/depayloader plugins
> 
> These are all fine now too.

Scratch that, dvdspu is not fine. The others are okay though.

Comment 7 Fedora Update System 2023-12-20 23:59:19 UTC

FEDORA-2023-5893a1a8aa has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5893a1a8aa

Comment 8 Fedora Update System 2023-12-21 00:00:14 UTC

FEDORA-2023-5893a1a8aa has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2023-12-21 05:02:32 UTC

FEDORA-2023-d9bca05694 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d9bca05694

Comment 10 Fedora Update System 2023-12-22 02:51:56 UTC

FEDORA-2023-d9bca05694 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-d9bca05694`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-d9bca05694

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-12-29 01:14:01 UTC

FEDORA-2023-d9bca05694 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.