Bug 2237562
Summary: | regression in g_key_file_get_string() on hand-written .ini files containing "\." or other invalid escapes | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Eric Blake <eblake> |
Component: | glib2 | Assignee: | Kalev Lember <klember> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | 38 | CC: | eblake, gnome-sig, klember, mcatanza, mclasen, rhughes, rstrode |
Target Milestone: | --- | Keywords: | Regression |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | glib2-2.77.3-2.fc40 glib2-2.77.3-2.fc39 glib2-2.76.5-2.fc38 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2024-04-11 01:02:41 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Eric Blake
2023-09-06 01:56:30 UTC
https://github.com/GNOME/glib/commit/71b7efd0 looks relevant. glib may have recently made intentional changes to g_key_file_parse_value_as_string() to start declaring \ before unusual character (like .) as an unrecognized escape, instead of its previous behavior of passing both the \ and next character on to the caller, but may have messed up error handling in the process. I didn't look further to see what other recent glib changes may be relevant. Looks like there's already a fix for this upstream: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3565 (In reply to Kalev Lember from comment #2) > Looks like there's already a fix for this upstream: > https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3565 Confirmed; I've commented on that merge commit upstream after testing locally that it fixes my issue. We'll definitely want to backport that into Fedora; according to glib, there are a number of other affected projects including Midnight Commander. Thanks! I went ahead and backported the upstream patch to F38, F39 and rawhide. |