Bug 2237656
| Summary: | Review Request: bluechi - A systemd service controller for multi-nodes environments | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pierre-YvesChibon <pingou> | ||||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | ngompa13, package-review | ||||||
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://github.com/containers/bluechi | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2023-09-15 01:35:08 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Pierre-YvesChibon
2023-09-06 08:02:52 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6375740 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2237656-bluechi/fedora-rawhide-x86_64/06375740-bluechi/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] I have two questions for the reviewer: a/ the project has been renamed due to a potential trademark issue. The renaming also changed the dbus API used to interact with the main service, so it's not quite a drop-in replacement. That being said: should bluechi obsolete hirte? On the one hand, yes because it's a semi-legal driven renaming, on the other hand, it's not a fully drop-in replacement since the API changed. Thoughts? b/ when importing bluechi into dist-git, should I preserve the history for the hirte git repo or start from a clean repo? Thanks :) Created attachment 1987255 [details]
The .spec file difference from Copr build 6375740 to 6375799
Copr build: https://copr.fedorainfracloud.org/coprs/build/6375799 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2237656-bluechi/fedora-rawhide-x86_64/06375799-bluechi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Created attachment 1987269 [details]
The .spec file difference from Copr build 6375799 to 6377539
Copr build: https://copr.fedorainfracloud.org/coprs/build/6377539 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2237656-bluechi/fedora-rawhide-x86_64/06377539-bluechi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this review. (In reply to Pierre-YvesChibon from comment #3) > I have two questions for the reviewer: > a/ the project has been renamed due to a potential trademark issue. The > renaming also changed the dbus API used to interact with the main service, > so it's not quite a drop-in replacement. That being said: should bluechi > obsolete hirte? On the one hand, yes because it's a semi-legal driven > renaming, on the other hand, it's not a fully drop-in replacement since the > API changed. > Thoughts? > I think for all the important points that matter, the full Obsoletes+Provides is fine. > b/ when importing bluechi into dist-git, should I preserve the history for > the hirte git repo or start from a clean repo? > > Thanks :) Up to you, though I prefer the history if you can keep it. Review notes: - package follows Fedora Packaging Guidelines - package builds and installs without errors on rawhide - test suite is run, unit tests pass - latest version is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files PACKAGE APPROVED. Small notes: > BuildRequires: git You should use "git-core" here, since you only need the core parts of git. > %autosetup -S git I'd recommend "%autosetup -S git_am" instead. You can make those changes on import if you so choose. Many thanks for the prompt review! Much appreciated :) I'll do the two suggested change, while they aren't used at the moment, it'll save me from remembering them next time :) Thanks again! The Pagure repository was created at https://src.fedoraproject.org/rpms/bluechi FEDORA-2023-7710f4bf9f has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7710f4bf9f FEDORA-2023-4da0fed184 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4da0fed184 FEDORA-2023-3a5d2b5919 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3a5d2b5919 FEDORA-2023-4da0fed184 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-4da0fed184 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-4da0fed184 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-3a5d2b5919 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-3a5d2b5919 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-3a5d2b5919 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-7710f4bf9f has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-7710f4bf9f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-7710f4bf9f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-3a5d2b5919 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-7710f4bf9f has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-4da0fed184 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |