Bug 2237860

Summary:	frr has a failure in the gating tests on F39 and F40/Rawhide
Product:	[Fedora] Fedora	Reporter:	Ben Beasley <code>
Component:	frr	Assignee:	Michal Ruprich <mruprich>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	39	CC:	fhrdina, mruprich, tkorbar, zpytela
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-02-02 15:41:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ben Beasley 2023-09-07 11:17:13 UTC

Description of problem:

In https://bodhi.fedoraproject.org/updates/FEDORA-2023-b5fb7bba8c, the exit code apparently differs from what the tests are expecting, causing the CI gating tests to fail:

Version-Release number of selected component (if applicable):

frr-8.5.2-4.fc39


How reproducible:


Steps to Reproduce:
1. Create a Bodhi update containing frr.


Actual results:

:: [ 02:33:42 ] :: [  BEGIN   ] :: Insufficient rights, restarting service under nonprivileged user must fail :: actually running 'su testuserqa -c 'systemctl restart frr''
Failed to restart frr.service: Access denied
See system logs and 'systemctl status frr.service' for details.
:: [ 02:33:42 ] :: [   FAIL   ] :: Insufficient rights, restarting service under nonprivileged user must fail (Expected 1, got 4)


Expected results:

Tests pass.


Additional info:

I am inclined to waive the failing test, as the details look harmless and unrelated to the abseil-cpp update, but I am waiting to see what happens in F40/Rawhide (https://bodhi.fedoraproject.org/updates/FEDORA-2023-48a12fa02e). I think this test timed out the first time in F40, but there were so many OpenQA failures (again, I think unrelated to the update) that I have re-triggered the tests.

Comment 1 Ben Beasley 2023-09-07 11:48:43 UTC

(In reply to Ben Beasley from comment #0)
> I am inclined to waive the failing test, as the details look harmless and
> unrelated to the abseil-cpp update, but I am waiting to see what happens in
> F40/Rawhide
> (https://bodhi.fedoraproject.org/updates/FEDORA-2023-48a12fa02e). I think
> this test timed out the first time in F40, but there were so many OpenQA
> failures (again, I think unrelated to the update) that I have re-triggered
> the tests.

Follow-up: the test failed in F40 the same way it did in F39. I’m waiving the test in F39 and referencing this bug report; if the OpenQA tests pass in F40, I’ll do the same there.

Let me know if there is anything else I should do.

Comment 2 Ben Beasley 2023-09-08 13:04:59 UTC

Waived in F40/Rawhide too.

Comment 3 Michal Ruprich 2023-09-11 06:03:18 UTC

Hi Ben,

sorry about that, I would have answered sooner but I was out for a couple of days. You did good to waive these, I need to fix them asap.

Regards,
Michal

Comment 4 Michal Ruprich 2024-02-02 15:41:47 UTC

No more failures of this kind in the latest FRR in Rawhide nor in F38 and F39. I am closing this now, make sure to re-open should the problem appear again.