Bug 2238154

Summary: Review Request: suitesparse-graphblas - Graph algorithms in the language of linear algebra
Product: [Fedora] Fedora Reporter: Benson Muite <benson_muite>
Component: Package ReviewAssignee: Tom.Rix
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review, Tom.Rix, trix
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-01-19 11:39:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Benson Muite 2023-09-09 14:41:01 UTC
spec: https://download.copr.fedorainfracloud.org/results/fed500/suitesparse-graphblas/fedora-rawhide-x86_64/06390081-suitesparse-graphblas/suitesparse-graphblas.spec
srpm: https://download.copr.fedorainfracloud.org/results/fed500/suitesparse-graphblas/fedora-rawhide-x86_64/06390081-suitesparse-graphblas/suitesparse-graphblas-8.2.0-1.fc40.src.rpm

Description:
SuiteSparse:GraphBLAS is a complete implementation of the GraphBLAS
standard, which defines a set of sparse matrix operations on an
extended algebra of semirings using an almost unlimited variety of
operators and types. When applied to sparse adjacency matrices,
these algebraic operations are equivalent to computations on graphs.
GraphBLAS provides a powerful and expressive framework for creating
graph algorithms based on the elegant mathematics of sparse matrix
operations on a semiring.

SuiteSparse:GraphBLAS is used heavily in production. It appears as
the underlying graph engine in the RedisGraph database by Redis,
and as the built-in sparse matrix multiply in MATLAB R2021a, where
C=A*B is now up to 30x faster than in prior versions of MATLAB (on
my 20-core NVIDIA DGX Station).

The development of this package is supported by Intel, NVIDIA
(including the donation of the 20-core DGX Station), Redis,
MIT Lincoln Lab, MathWorks, IBM, and Julia Computing.

fas: fed500

Reproducible: Always

Comment 1 Tom Rix 2023-12-30 12:59:11 UTC
Can you repost the spec and srpm ?
The links are dead.

Comment 3 Fedora Review Service 2024-01-09 11:31:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6875360
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2238154-suitesparse-graphblas/fedora-rawhide-x86_64/06875360-suitesparse-graphblas/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Tom Rix 2024-01-09 15:03:04 UTC
Some bigger things.
The bundled packages need a license breakdown.  Add the version info if you can or comment that it is a hacked version.

can third party not listed in the bundled, CUDA/ and cpu_features/ be rm-ed in the prep ?

How does this package interact with suitesparse ?
I see from the graphblas comments that is has been sync-ed to the latest suitesparse 7.7, but Fedora's version is 5.3.
The Fedora suitesparse also has a quite a bit more complicated build options, graph sparse does not.

I see a lot of matlab comments, will this be integrated into octave ?

Comment 5 Benson Muite 2024-01-17 17:58:28 UTC
Thanks for the feedback. GraphBLAS develops a bit faster than suitesparse though they do sync at suitesparse release time.

Comment 6 Tom Rix 2024-01-19 12:57:42 UTC
Is it necessary to keep suitesparse and graphblas somewhat in sync in fedora ?
should suitesparse but updated to 7.7 ?

Comment 7 Package Review 2024-12-31 08:06:06 UTC
This is an automatic action taken by review-stats script.

The reviewer account doesn't exist anymore, therefore this ticket will be resetted.

Comment 8 Tom.Rix 2025-01-06 22:34:33 UTC
Sorry it took me a while to find my old review.
Do you want to continue with this package ?

Comment 9 Benson Muite 2025-01-19 11:39:22 UTC
No. It is part of suitesparse.