Bug 2238243

Summary: Seg fault for cdrdao read-toc without --datafile
Product: [Fedora] Fedora Reporter: simon.siemens
Component: cdrdaoAssignee: Pavel Cahyna <pcahyna>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 39CC: be.0, denis, hhorak, overact_ninetieth160, pcahyna, pikachu.2014
Target Milestone: ---Keywords: Regression
Target Release: ---   
Hardware: x86_64   
OS: Linux   
URL: https://github.com/cdrdao/cdrdao/issues/22
Whiteboard:
Fixed In Version: cdrdao-1.2.5-6.fc39 cdrdao-1.2.5-6.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-11-25 02:42:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description simon.siemens 2023-09-10 20:03:26 UTC 
On Fedora 38 and 39, cdrdao read-toc fails, if the user omits the optional parameter --datafile.

The reason is a missing initialization of the string pointer dataFilename. For details see

* issue https://github.com/cdrdao/cdrdao/issues/22 and
* pull request https://github.com/cdrdao/cdrdao/pull/21.

Could we have the patch of the pull request #21 in Fedora 39 already? The bug makes some tools like whipper useless.

This seems to be a regression in cdrdao 1.2.5.

Reproducible: Always

Steps to Reproduce:
1. Put an audio cd in the cd drive.
2. Run `cdrdao read-toc read.toc`
Actual Results:  
Program output

    [~]$ cdrdao read-toc read.toc
    /dev/sr0: PIONEER BD-RW BDR-XD07U Rev: 1.01
    Using driver: Generic SCSI-3/MMC - Version 2.0 (options 0x0000)

    Reading toc data...

    Track Mode Flags Start Length
    ------------------------------------------------------------
    1 AUDIO 0 00:00:00( 0) 01:25:28( 6403)
...
    25 AUDIO 0 77:00:28(346528) 03:02:58( 13708)
    Leadout AUDIO 0 80:03:11(360236)

    PQ sub-channel reading (audio track) is supported, data format is BCD.
    Raw P-W sub-channel reading (audio track) is supported.
    Program received signal SIGSEGV, Segmentation fault.

The toc file is not created.

Expected Results:  
* No seg fault
* The toc file is created

cdrdao package: 
* Version      : 1.2.5
* Release      : 5.fc39
Comment 1 Adam Williamson 2023-11-16 21:39:21 UTC 
*** Bug 2241061 has been marked as a duplicate of this bug. ***
Comment 2 Fedora Update System 2023-11-16 21:58:36 UTC 
FEDORA-2023-28316fd35e has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-28316fd35e
Comment 3 Fedora Update System 2023-11-16 21:58:36 UTC 
FEDORA-2023-6d34acdd1c has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-6d34acdd1c
Comment 4 Fedora Update System 2023-11-17 03:05:21 UTC 
FEDORA-2023-6d34acdd1c has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-6d34acdd1c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-6d34acdd1c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 5 Fedora Update System 2023-11-17 03:05:58 UTC 
FEDORA-2023-28316fd35e has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-28316fd35e`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-28316fd35e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 6 Fedora Update System 2023-11-25 02:42:44 UTC 
FEDORA-2023-28316fd35e has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 7 Fedora Update System 2023-11-25 02:54:27 UTC 
FEDORA-2023-6d34acdd1c has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 8 simon.siemens 2023-12-03 06:30:21 UTC 
I confirm the issue is fixed in Fedora 39.

Version     : 1.2.5
Release     : 6.fc39

Thanks for the effort downstream.