Bug 2238752

Summary:	Please drop rubygem-shoulda from Fedora
Product:	[Fedora] Fedora	Reporter:	Vít Ondruch <vondruch>
Component:	rubygem-shoulda	Assignee:	Troy Dawson <tdawson>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	tdawson
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-09-13 16:35:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vít Ondruch 2023-09-13 13:27:28 UTC

Please drop rubygem-shoudla from Fedora for several reasons:

1) It is not well maintained upstream. E.g. 
 a) it does not have proper support for Ruby on Rails 7 and even upstream admits that Shoulda (essentially just metagem) is not their priority.
 b) it depends on shoulda-matchers 4, while shoulda-matchers 5 is out for more the two years.

2) It introduces new test dependencies, such as snowglobe [1], which makes the test coverage mostly non-existing due to snowglobe nature (downloading Ruby on Rails from the internet).

3) Shoulda is generally not the most used test framework today

4) I have made sure that nothing depends on it in Fedora:

~~~
$ sudo dnf repoquery --disablerepo=* --enablerepo=rawhide --enablerepo=rawhide-source --whatrequires "rubygem-shoulda" --whatrequires "rubygem(shoulda)"
[sudo] heslo pro vondruch: 
Updating and loading repositories:
Repositories loaded.
rubygem-shoulda-doc-0:4.0.0-1.fc40.noarch
~~~

5) I'll be able to drop rubygem-shoulda-matchers, which is required just by rubygem-shoudla (I'll soon do it anyway, I just want to make it the right way)



[1]: https://github.com/thoughtbot/shoulda/commit/3132c10239c0f6e3546ffb82010c249f8ad873b9

Reproducible: Always

Comment 1 Troy Dawson 2023-09-13 13:36:12 UTC

I'm not sure how I became the main admin for rubygem-shoulda, but sure, I'm fine with dropping it.

Comment 2 Troy Dawson 2023-09-13 13:39:54 UTC

Did you want to remove it, with my blessing?
I'm right in the middle of things and won't be able to get to it for a week.

Comment 3 Vít Ondruch 2023-09-13 15:06:58 UTC

(In reply to Troy Dawson from comment #1)
> I'm not sure how I became the main admin for rubygem-shoulda, but sure, I'm
> fine with dropping it.

Probably via some dependency chain.

(In reply to Troy Dawson from comment #2)
> Did you want to remove it, with my blessing?
> I'm right in the middle of things and won't be able to get to it for a week.

1) I don't think I have the power to drop it
2) Orphaning is fine
3) Whenever you get a chance. This is just low priority

Comment 4 Troy Dawson 2023-09-13 15:52:02 UTC

I have the time to orphan.
I have orphaned it.

Comment 5 Vít Ondruch 2023-09-13 16:35:20 UTC

(In reply to Troy Dawson from comment #4)
> I have the time to orphan.
> I have orphaned it.

Thx a bunch. I'm closing this as resolved.