Bug 2239185

Summary: Review Request: rust-gix-transport - Implementation of the git transport layer used by gix
Product: [Fedora] Fedora Reporter: blinxen <h-k-81>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-09-27 16:46:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description blinxen 2023-09-15 19:07:20 UTC
Spec URL: https://blinxen.fedorapeople.org/rust-gix-transport/rust-gix-transport.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-gix-transport/rust-gix-transport-0.36.0-1.fc40.src.rpm

Description:
A crate of the gitoxide project dedicated to implementing the git
transport layer.

Fedora Account System Username: blinxen

Comment 1 Fabio Valentini 2023-09-17 13:14:41 UTC
Packages don't install cleanly:

===

Error: 
 Problem 1: conflicting requests
  - nothing provides (crate(gix-credentials/default) >= 0.19.0 with crate(gix-credentials/default) < 0.20.0~) needed by rust-gix-transport+gix-credentials-devel-0.36.0-1.fc40.noarch from @commandline
 Problem 2: package rust-gix-transport+http-client-devel-0.36.0-1.fc40.noarch from @commandline requires crate(gix-transport/gix-credentials) = 0.36.0, but none of the providers can be installed
  - conflicting requests
  - nothing provides (crate(gix-credentials/default) >= 0.19.0 with crate(gix-credentials/default) < 0.20.0~) needed by rust-gix-transport+gix-credentials-devel-0.36.0-1.fc40.noarch from @commandline
 Problem 3: package rust-gix-transport+http-client-curl-devel-0.36.0-1.fc40.noarch from @commandline requires crate(gix-transport/http-client) = 0.36.0, but none of the providers can be installed
  - package rust-gix-transport+http-client-devel-0.36.0-1.fc40.noarch from @commandline requires crate(gix-transport/gix-credentials) = 0.36.0, but none of the providers can be installed
  - conflicting requests
  - nothing provides (crate(gix-credentials/default) >= 0.19.0 with crate(gix-credentials/default) < 0.20.0~) needed by rust-gix-transport+gix-credentials-devel-0.36.0-1.fc40.noarch from @commandline
 Problem 4: package rust-gix-transport+http-client-reqwest-devel-0.36.0-1.fc40.noarch from @commandline requires crate(gix-transport/http-client) = 0.36.0, but none of the providers can be installed
  - package rust-gix-transport+http-client-devel-0.36.0-1.fc40.noarch from @commandline requires crate(gix-transport/gix-credentials) = 0.36.0, but none of the providers can be installed
  - conflicting requests
  - nothing provides (crate(gix-credentials/default) >= 0.19.0 with crate(gix-credentials/default) < 0.20.0~) needed by rust-gix-transport+gix-credentials-devel-0.36.0-1.fc40.noarch from @commandline
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)

===

It looks like the "gix-credentials" crate will need to be packaged before this one.

Comment 2 blinxen 2023-09-26 20:01:18 UTC
@decathorpe You can continue with the review now :D

Comment 3 Fabio Valentini 2023-09-26 20:20:27 UTC
Please update to v0.36.1:
https://rustsec.org/advisories/RUSTSEC-2023-0064.html

Comment 5 Fabio Valentini 2023-09-26 22:36:30 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
? test suite is run and all unit tests pass (there are no tests)
! latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

v0.37.0 is out, but likely requires *all* gix crates to be updated. So having v0.36.1 now is fine.

Comment 6 Fedora Admin user for bugzilla script actions 2023-09-27 16:30:02 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix-transport

Comment 7 Fedora Update System 2023-09-27 16:44:23 UTC
FEDORA-2023-35519d7dcb has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-35519d7dcb

Comment 8 Fedora Update System 2023-09-27 16:46:43 UTC
FEDORA-2023-35519d7dcb has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.