Bug 2239319

Summary:	Review Request: rust-libcst_derive - Proc macro helpers for libcst
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Michel Lind <michel>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	michel, package-review
Target Milestone:	---	Flags:	michel: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rust-libcst_derive-0.1.0-1.fc40	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-09-18 21:43:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Fabio Valentini 2023-09-17 11:56:35 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-libcst_derive.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-libcst_derive-0.1.0-1.fc38.src.rpm

Description:
Proc macro helpers for libcst.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-09-17 11:56:37 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=106301146

Comment 2 Michel Lind 2023-09-18 20:59:06 UTC

There are references to files with other licenses in LICENSE, but those files are not in this crate, so all looks good

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 3 Fedora Admin user for bugzilla script actions 2023-09-18 21:21:15 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libcst_derive

Comment 4 Fabio Valentini 2023-09-18 21:43:16 UTC

Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-97806ba09e