Bug 2239505

Summary:	Review Request: rust-gix-diff - Calculate differences between various git objects
Product:	[Fedora] Fedora	Reporter:	blinxen <h-k-81>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-09-24 15:04:43 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description blinxen 2023-09-18 17:45:32 UTC

Spec URL: https://blinxen.fedorapeople.org/rust-gix-diff/rust-gix-diff.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-gix-diff/rust-gix-diff-0.35.0-1.fc40.src.rpm

Description:
Calculate differences between various git objects.

Fedora Account System Username: blinxen

Comment 1 blinxen 2023-09-18 17:45:35 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=106357375

Comment 2 Fabio Valentini 2023-09-21 13:22:24 UTC

Packages do not install cleanly:

Error: 
 Problem: conflicting requests
  - nothing provides (crate(getrandom/js) >= 0.2.8 with crate(getrandom/js) < 0.3.0~) needed by rust-gix-diff+wasm-devel-0.35.0-1.fc40.noarch from @commandline
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)


Please verify that packages build *and* install successfully (i.e. by using the "--postinstall" argument for mock).

In this case, remove the wasm feature and the getrandom/js dependency.
We do not support building for WASM targets, and don't have the dependencies necessary for it.

Comment 3 blinxen 2023-09-21 19:27:47 UTC

> Please verify that packages build *and* install successfully (i.e. by using the "--postinstall" argument for mock).

Will do that in the future :D

Removed the "wasm" feature and its dependencies.

Links to the uploaded files:
Spec URL: https://blinxen.fedorapeople.org/rust-gix-diff/rust-gix-diff.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-gix-diff/rust-gix-diff-0.35.0-1.fc40.src.rpm

Comment 4 Fabio Valentini 2023-09-24 14:35:58 UTC

Thanks for the update!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Fedora Admin user for bugzilla script actions 2023-09-24 14:49:45 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix-diff

Comment 6 Fedora Update System 2023-09-24 15:03:30 UTC

FEDORA-2023-0052bff1e8 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0052bff1e8

Comment 7 Fedora Update System 2023-09-24 15:04:43 UTC

FEDORA-2023-0052bff1e8 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.