Bug 2239622

Summary:	When creating a new pool, we show device type HDD without an option to select SSD
Product:	[Red Hat Storage] Red Hat OpenShift Data Foundation	Reporter:	Eran Tamir <etamir>
Component:	management-console	Assignee:	Sanjal Katiyar <skatiyar>
Status:	CLOSED ERRATA	QA Contact:	Vijay Avuthu <vavuthu>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.13	CC:	ebenahar, kbg, muagarwa, odf-bz-bot, sapillai, skatiyar, vavuthu
Target Milestone:	---
Target Release:	ODF 4.14.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	4.14.0-136	Doc Type:	Bug Fix
Doc Text:	Previously, for the internal OpenShift Data Foundation installations, the user interface showed HDD, SSD, or both in the Volume type drop down for the existing clusters even though the internal installations should have assumed the disks to be SSD. With this fix, Volume type dropdown is removed from the user interface and always assume it to be SSD.	Story Points:	---
Clone Of:
Clones:	2241179 (view as bug list)		Environment:
Last Closed:	2023-11-08 18:54:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2241179, 2244409, 2249001

Description Eran Tamir 2023-09-19 12:49:47 UTC

Description of problem (please be detailed as possible and provide log
snippests):
When creating a new pool, we show device type HDD without an option to select SSD. 
We should hide this field and use only SSD. 

Can this issue reproducible?
Yes. Simply create a new pool

Can this issue reproduce from the UI?
Yes. It's a UI bug

If this is a regression, please provide more details to justify this:

Can't tell

Comment 3 Sanjal Katiyar 2023-09-19 13:10:09 UTC

as per discussion with Eran, need to backport to 4.13 and 4.12 as well.

Comment 4 Mudit Agarwal 2023-09-19 13:11:53 UTC

Santosh, JFYI. We should have addressed this in https://issues.redhat.com/browse/RHSTOR-4326?

Comment 8 Santosh Pillai 2023-09-21 06:49:40 UTC

(In reply to Mudit Agarwal from comment #4)
> Santosh, JFYI. We should have addressed this in
> https://issues.redhat.com/browse/RHSTOR-4326?

RHSTOR-4326 was for the new OSDs only. We don't have a way in Rook to automatically change the Deviceclass of existing OSDs.
But agree that we should have discussed the pool creation UI flow when discussing RHSTOR-4326. I didn't know that the UI was reading the inputs from `cephCluster.status.storage.deviceClasses`

Comment 9 Vijay Avuthu 2023-11-07 10:13:04 UTC

Verified with ocs-registry:4.14.0-161

> Install ODF using ocs-ci
> create new BlockPool in UI ( test both with and without compression )
> check blockpool is in Ready state or not

$ oc get cephblockpool
NAME                               PHASE
ocs-storagecluster-cephblockpool   Ready
testblockpool                      Ready
testertytweyur                     Ready
testpool-compression1              Ready

> tested with custom deviceClass in StorageCluster but creation is failed. raised separate for this scenario bug https://bugzilla.redhat.com/show_bug.cgi?id=2248487

Marking as Verified this bug

Comment 12 errata-xmlrpc 2023-11-08 18:54:31 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.14.0 security, enhancement & bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6832