Bug 2239767
| Summary: | Delete oprhan content task doesn't remove orphaned remotes in the Capsule | ||
|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Hao Chang Yu <hyu> |
| Component: | Capsule - Content | Assignee: | Samir Jha <sajha> |
| Status: | CLOSED ERRATA | QA Contact: | Sam Bible <sbible> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.13.5 | CC: | jpasqual, jsenkyri, rlavi, sajha, sbible |
| Target Milestone: | 6.15.0 | Keywords: | Triaged |
| Target Release: | Unused | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-04-23 17:14:38 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Created redmine issue https://projects.theforeman.org/issues/36787 from this bug Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/36787 has been resolved. Steps to Reproduce: 1. On Satellite, enable and sync 120 repositories. 2. Add these to a CV, and promote to 2 different LCEs. 3. Add the LCEs to the Capsule. 5. Publish and promote the content views which should trigger auto Capsule sync. 6. Remove some repositories from the content views, and then publish and promote new versions. 7. Trigger delete orphan content task ~~~ foreman-rake katello:delete_orphaned_content ~~~ Actual results: The orphaned content task is triggered and completed. Expected results: The orphaned content task is triggered and completed. Orphaned content on capsule is removed. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: Satellite 6.15.0 release), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2024:2010 |
Description of problem: If a Capsule has more than 100 Pulp 3 remotes, the delete orphan content task will fail to scan for any orphan Pulp 3 remotes in the Capsule. This is because Pulp API by default only returns 100 records. If a Capsule has more than 100 Pulp 3 remotes, then part of the remotes will not be returned by the API call. app/services/katello/pulp3/smart_proxy_mirror_repository.rb ~~~ def delete_orphan_remotes tasks = [] smart_proxy_helper = ::Katello::SmartProxyHelper.new(smart_proxy) repo_names = smart_proxy_helper.combined_repos_available_to_capsule.map(&:pulp_id) acs_remotes = Katello::SmartProxyAlternateContentSource.pluck(:remote_href) pulp3_enabled_repo_types.each do |repo_type| api = repo_type.pulp3_api(smart_proxy) remotes = api.remotes_list <==================== This call will only return 100 remotes remotes.each do |remote| if !repo_names.include?(remote.name) && !acs_remotes.include?(remote.pulp_href) tasks << api.delete_remote(remote.pulp_href) end end end tasks end ~~~ If you replace the line with the following line then the issue is fixed. ~~~ remotes = api.remotes_list(limit: 10000) ~~~ How reproducible: easy Steps to Reproduce: 1. On Satellite, enable and sync some repositories. 2. Create some content views and some LCEs and then attach the repositories to the CVs. 3. Add the LCEs to the Capsule. 4. Make sure the total number of content views' repositories * number of LCEs > 200. It is because the higher the easier to reproduce the issue. 5. Publish and promote the content views which should trigger auto Capsule sync. 6. Remove some repositories from the content views, and then publish and promote new versions. 7. Trigger delete orphan content task ~~~ foreman-rake katello:delete_orphaned_content ~~~ Actual results: Either no orphan remotes are deleted or some orphan remotes are not deleted. Expected results: Delete all orphan remotes in the Capsule. Additional infos: Leaving the orphan remotes undeleted might cause the Pulp content app to pick the wrong/outdated remote to download contents. It will then fail to download content using the wrong/outdated remote.