Bug 2239883

Summary:	Adding missing Requires: to ucarp.spec
Product:	[Fedora] Fedora EPEL	Reporter:	farrotin
Component:	ucarp	Assignee:	Gwyn Ciesla <gwync>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	epel9	CC:	fabian.deutsch, gwync
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ucarp-1.5.2-33.el9 ucarp-1.5.2-33.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-10-05 02:02:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description farrotin 2023-09-20 15:45:01 UTC

Description of problem:

ucarp has the script /usr/libexec/ucarp/ucarp that is calling 'daemon' to launch ucarp process per virtual interface.
But nothing provides 'daemon' as it's a function that is sourced through /etc/init.d/functions (see head of that /usr/libexec/ucarp/ucarp file) but so missing from el9 (and probably el8 too) as initscripts package is present but not installed by default

Version-Release number of selected component (if applicable):
ucarp-1.5.2-32.el9.x86_64

How reproducible:
always

Steps to Reproduce:
1. install ucarp
2. configure vip
3. try to start with 'systemctl start ucarp@001'

Actual results:
ucarp would add the configured VIP

Expected results:
it doesn't and fails with :
Sep 20 10:52:46 ip-172-19-4-121 ucarp[27909]: Starting common address redundancy protocol daemon:
Sep 20 10:52:46 ip-172-19-4-121 ucarp[27915]: /usr/libexec/ucarp/ucarp: line 36: failure: command not found


Additional info:

As said, that 'daemon' function is coming from /etc/init.d/functions, so just adding `Requires: initscripts` in ucarp.spec would satisfy runtime dependencies for ucarp and so adding virtual ip addresses

Comment 1 farrotin 2023-09-21 07:04:57 UTC

Just to mention that the /usr/libexec/ucarp/ucarp helper scripts seems to come from pkg and not upstream so maybe you can also decide to not Require: initscripts and so just plumb that daemon() function directly into the ucarp helper script and so not have external dependency just for that function ?
I'll let you judge as maintainer what's the best/easiest :)

Comment 2 Fedora Update System 2023-09-26 19:06:54 UTC

FEDORA-EPEL-2023-dd027620b9 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-dd027620b9

Comment 3 Fedora Update System 2023-09-26 19:06:55 UTC

FEDORA-EPEL-2023-2d40b8447f has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-2d40b8447f

Comment 4 Fedora Update System 2023-09-27 02:40:40 UTC

FEDORA-EPEL-2023-dd027620b9 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-dd027620b9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2023-09-27 02:46:32 UTC

FEDORA-EPEL-2023-2d40b8447f has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-2d40b8447f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2023-10-05 02:02:13 UTC

FEDORA-EPEL-2023-dd027620b9 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2023-10-05 02:23:38 UTC

FEDORA-EPEL-2023-2d40b8447f has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.