Bug 2240029

Summary: Expired clone token not reported as permanent failure in DV status
Product: Container Native Virtualization (CNV) Reporter: Alex Kalenyuk <akalenyu>
Component: StorageAssignee: Adam Litke <alitke>
Status: CLOSED MIGRATED QA Contact: dalia <dafrank>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.13.4CC: dafrank, ycui
Target Milestone: ---   
Target Release: 4.13.5   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-12-14 16:04:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Alex Kalenyuk 2023-09-21 12:15:55 UTC 
Description of problem:
A clone token is never going to become valid again so we can communicate a terminal state in such case.

Version-Release number of selected component (if applicable):
CNV 4.13.4 and lower

How reproducible:
100%

Steps to Reproduce:
1. Create cross namespace clone DV from non existing source PVC
2. Wait 5~ minutes
3. Create the source

Actual results:
No indication that the DV will never converge

Expected results:
Terminal Failed DV phase since token expired

Additional info:
One approach is to backport something along the lines of https://github.com/kubevirt/containerized-data-importer/pull/2742
Since this is no longer a problem in main.
Comment 1 dalia 2023-10-18 12:33:57 UTC 
Alex, is it fixed in 4.14?
Comment 2 Alex Kalenyuk 2023-10-25 13:12:16 UTC 
(In reply to dalia from comment #1)
> Alex, is it fixed in 4.14?

Yes, very hard to reproduce though
Comment 3 Alex Kalenyuk 2023-10-25 13:13:03 UTC 
(In reply to Alex Kalenyuk from comment #2)
> (In reply to dalia from comment #1)
> > Alex, is it fixed in 4.14?
> 
> Yes, very hard to reproduce though

Correction: No, very hard to reproduce though