Bug 2240778

Summary: [ODF 4.12][MCG: DB password showing up in clear text in core and endpoint pod logs]
Product: [Red Hat Storage] Red Hat OpenShift Data Foundation Reporter: nravinas
Component: Multi-Cloud Object GatewayAssignee: Danny <dzaken>
Status: CLOSED ERRATA QA Contact: Tiffany Nguyen <tunguyen>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.12CC: csharpe, edonnell, nbecker, odf-bz-bot, tdesala
Target Milestone: ---   
Target Release: ODF 4.14.0   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: 4.14.0-147 Doc Type: Bug Fix
Doc Text:
.Postgresql DB password no longer displayed in clear text in core and endpoint logs Previously, the internal Postgresql client in noobaa-core printed a connections parameters object to the log, and this object contained the password to connect to Postgresql DB. With this fix, the password information is omitted from the connection object that is printed to the log, and the messages to the logs contain only the nonsensitive connection details.
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-11-08 18:54:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2244409    

Description nravinas 2023-09-26 13:14:29 UTC
Description of problem (please be detailed as possible and provide log
snippests):

The pod logs for the core and endpoint MCG pods show the database password in clear text.

Comment 4 Nimrod Becker 2023-10-04 12:55:18 UTC
Was fixed as a larger fix (Epic for 4.15) https://github.com/noobaa/noobaa-core/pull/7504
Trying to see if we can backport only the password thing

Comment 8 Tiffany Nguyen 2023-10-19 03:15:07 UTC
Verified with build "4.14.0-154", there is no DB password showing up in clear text in both noobaa-core and noobaa-endpoint pod logs:


Snipped from noobaa-core logs:

Oct-19 3:08:29.341 [Upgrade/20]    [L0] core.util.postgres_client:: connect called, current url { max: 10, host: 'noobaa-db-pg-0.noobaa-db-pg', user: 'noobaa', database: 'nbcore', port: 5432 }
Oct-19 3:08:29.341 [Upgrade/20]    [L0] core.util.postgres_client:: _connect: called with { max: 10, host: 'noobaa-db-pg-0.noobaa-db-pg', user: 'noobaa', database: 'nbcore', port: 5432 }
Oct-19 3:08:29.764 [Upgrade/20]    [L0] core.util.postgres_client:: _connect: connected { max: 10, host: 'noobaa-db-pg-0.noobaa-db-pg', user: 'noobaa', database: 'nbcore', port: 5432 }

Snipped from noobaa-endpoint logs:

Oct-19 2:58:12.165 [Endpoint/13]    [L0] core.util.postgres_client:: connect called, current url { max: 80, host: 'noobaa-db-pg-0.noobaa-db-pg', user: 'noobaa', database: 'nbcore', port: 5432 }
Oct-19 2:58:12.166 [Endpoint/13]    [L0] core.util.postgres_client:: _connect: called with { max: 80, host: 'noobaa-db-pg-0.noobaa-db-pg', user: 'noobaa', database: 'nbcore', port: 5432 }
Oct-19 2:58:12.858 [Endpoint/13]    [L0] core.util.postgres_client:: _connect: connected { max: 80, host: 'noobaa-db-pg-0.noobaa-db-pg', user: 'noobaa', database: 'nbcore', port: 5432 }

Comment 10 errata-xmlrpc 2023-11-08 18:54:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.14.0 security, enhancement & bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6832