Bug 2240967

Summary:	Review Request: pthreadpool - A PyTorch threading utility
Product:	[Fedora] Fedora	Reporter:	Tom Rix <trix>
Component:	Package Review	Assignee:	Onuralp Sezer <thunderbirdtr>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, thunderbirdtr
Target Milestone:	---	Flags:	thunderbirdtr: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-10-02 19:31:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1011110

Description Tom Rix 2023-09-27 12:02:37 UTC

Spec URL: https://trix.fedorapeople.org/pthreadpool.spec
SRPM URL: https://trix.fedorapeople.org/pthreadpool-1.0%5egit20230829.4fe0e1e-1.fc40.src.rpm

pthreadpool is a portable and efficient thread pool                                                                                           
implementation. It provides similar functionality                                                                                             
to #pragma omp parallel for, but with additional features.                                                                                    
                                                                                                                                              
Features:                                                                                                                                     
* C interface (C++-compatible).                                                                                                               
* 1D-6D loops with step parameters.                                                                                                           
* Run on user-specified or auto-detected number of threads.                                                                                   
* Work-stealing scheduling for efficient work balancing.                                                                                      
* Wait-free synchronization of work items.                                                                                                    
* Compatible with Linux (including Android), macOS,                                                                                           
  iOS, Windows, Emscripten environments.                                                                                                      
* 100% unit tests coverage.                                                                                                                   
* Throughput and latency microbenchmarks.  

The intended use of pthreadpool in PyTorch is shown here https://github.com/trixirt/pytorch-fedora/blob/main/pytorch.spec#L8 and has been in test for a while but needed fxdiv to packaged first.

Reproducible: Always

Comment 1 Onuralp Sezer 2023-10-02 11:57:12 UTC

I am taking this review

Comment 2 Onuralp Sezer 2023-10-02 11:59:34 UTC

First thing I notice is version part and it should be like this

Version:        0            
Release:        1.%{date0}git%{shortcommit0}%{?dist}

And license is not MIT but BSD

https://github.com/Maratyszcza/pthreadpool/blob/master/LICENSE

Comment 3 Tom Rix 2023-10-02 12:38:54 UTC

Spec URL: https://trix.fedorapeople.org/pthreadpool.spec
SPRM URL: https://trix.fedorapeople.org/pthreadpool-0.0%5egit20230829.4fe0e1e-2.fc40.src.rpm

With the requested changes.
Thanks for the review!

Comment 4 Onuralp Sezer 2023-10-02 14:05:35 UTC

* Package follows Fedora packaging guidelines
* Package builds and installs
* Package licensing looks correct
* No serious issues in rpmlint

Everything looks good

PACKAGE APPROVED.

Comment 5 Fedora Admin user for bugzilla script actions 2023-10-02 14:18:43 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/pthreadpool