Bug 2241052

Summary: Review Request: rust-gix-filter - Git filters implementation
Product: [Fedora] Fedora Reporter: blinxen <h-k-81>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-09-29 18:46:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description blinxen 2023-09-27 20:12:30 UTC
Spec URL: https://blinxen.fedorapeople.org/rust-gix-filter/rust-gix-filter.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-gix-filter/rust-gix-filter-0.4.0-1.fc40.src.rpm

Description:
A crate of the gitoxide project implementing git filters.

Fedora Account System Username: blinxen

Comment 1 blinxen 2023-09-27 20:12:32 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=106801069

Comment 2 blinxen 2023-09-27 20:23:41 UTC
This review should probably wait until https://github.com/Byron/gitoxide/discussions/1040 is resolved.

Comment 3 Michel Lind 2023-09-28 23:05:21 UTC
The discussion upstream seems to indicate this won't be fixed anytime soon - and in any case, rust-gix-packetline-blocking is already in Fedora, so the harm is done :). we can always retire that once it is no longer needed.

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged -- but that's fine, please update once everything 
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Fedora Admin user for bugzilla script actions 2023-09-29 18:33:17 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix-filter

Comment 5 Fedora Update System 2023-09-29 18:43:32 UTC
FEDORA-2023-8df74f63e0 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8df74f63e0

Comment 6 Fedora Update System 2023-09-29 18:46:44 UTC
FEDORA-2023-8df74f63e0 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.