Bug 2241350

Summary: FTBFS: dolphin-emu
Product: [Fedora] Fedora Reporter: Lukas Javorsky <ljavorsk>
Component: dolphin-emuAssignee: Jeremy Newton <alexjnewt>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: alexjnewt
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: dolphin-emu-5.0.19870-1.fc40 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-10-02 18:37:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2235710    

Description Lukas Javorsky 2023-09-29 13:14:55 UTC
We want to rebase minizip-ng in a side-tag (as there was a soname bump) however, the dolphin-emu (which requires the minizip soname) is FTBFS

I've tried a simple scratch-build with no changes on RPM (on Fedora Rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=106188415

Error: 
/builddir/build/BUILD/dolphin-423c7c58cd8fe78eb89a3ab434cfbc958a4eef07/Source/Core/Core/HW/EXI/BBA/BuiltIn.h:23:15: error: expected unqualified-id before numeric constant
   23 | constexpr u16 IP_PROTOCOL = 0x800;
      |               ^~~~~~~~~~~

Reproducible: Always

Steps to Reproduce:
1. Build dolphin-emu
2.
3.
Actual Results:  
FTBFS

Expected Results:  
Build successful

Comment 1 Jeremy Newton 2023-09-30 22:03:50 UTC
Thanks, yes I was looking into this, but I'm not sure how the constexpr feature in c++ works, so it might take me some time to figure out how to fix.

Comment 2 Fedora Update System 2023-10-02 18:36:57 UTC
FEDORA-2023-c57adcbd74 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c57adcbd74

Comment 3 Fedora Update System 2023-10-02 18:37:43 UTC
FEDORA-2023-c57adcbd74 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.