Bug 2241578
| Summary: | Review Request: qt6-qthttpserver - Library to facilitate the creation of an http server with Qt | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Cossette <farchord> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jgrulich, ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-10-01 17:12:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1917559 | ||
|
Description
Steve Cossette
2023-10-01 01:28:02 UTC
Taking this review. Initial spec review: > URL: https://github.com/qt/qthttpserver This is the wrong site for Qt stuff. It should be: http://qt-project.org/ > Source0: %{URL}/archive/refs/tags/v%{version}.tar.gz Qt releases official sources. You probably want to use a structure similar to what we have for qt6-qtbase: https://src.fedoraproject.org/rpms/qt6-qtbase/blob/rawhide/f/qt6-qtbase.spec#_48-52 > Requires: %{name}-doc We don't make documentation required for the main package. Drop this. > %autosetup -n qthttpserver-%{version} -p1 This line will change once you switch to official sources. Updated > %{_qt6_libdir}/libQt6HttpServer.so.6
> %{_qt6_libdir}/libQt6HttpServer.so.6.5.2
These can be simplified to: "%{_qt6_libdir}/libQt6HttpServer.so.6{,.*}"
Re-updated, thanks! Forgot to add qt6-rpm-macros. It gets pulled in by the other components but it was probably a good idea to add anyway. Fixed > License: BSD-3-Clause AND GFDL-1.3-no-invariants-only AND GPL-3.0-only AND Qt-GPL-exception-1.0
The last clause should be "GPL-3.0-only WITH Qt-GPL-exception-1.0"
Updated The doc package should be renamed to examples package, since that's what it actually contains. See qt6-qtbase for what that looks like. > %{_qt6_libdir}/qt6/examples/httpserver/colorpalette/colorpaletteserver
> %{_qt6_libdir}/qt6/examples/httpserver/simple/simple
This can be simplified to "%{_qt6_libdir}/qt6/examples/" as it's fine for -examples packages to co-own the base examples directory.
-examples package should require the -devel package instead of the base one. (In reply to Neal Gompa from comment #10) > > %{_qt6_libdir}/qt6/examples/httpserver/colorpalette/colorpaletteserver > > %{_qt6_libdir}/qt6/examples/httpserver/simple/simple > > This can be simplified to "%{_qt6_libdir}/qt6/examples/" as it's fine for > -examples packages to co-own the base examples directory. Done, used qt6-qtbase as a base. Also noticed that there is a cmake macro for qt6 for building (A bit like kf5 does) so I changed it to that, and added ninja-build as a BuildRequires. I didn't actually see your comment about changing what the -examples package requires. Fixed that too just now. Trailing slash missing on "%{_qt6_libdir}/qt6/examples".
Updated! Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint PACKAGE APPROVED. Thank you for the review, Neal! https://pagure.io/releng/fedora-scm-requests/issue/56692 The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6-qthttpserver |