Bug 2241633

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=106954013

I took a look at this package - its not an official review as I am not a member of the packaging group.

The package was generated with rust2rpm.

- The package builds and installs on rawhide (tested on x86_64)
- Unit tests are run and pass successfully (2 ignored out of 216)
- The version packaged matches the latest released version on crates.io and upstream repo.
- Included License in package matches that of the upstream (MIT or Apache 2.0) - should be acceptable for Fedora
- Licenses and docs included in %files
- rpmlint completes without any errors or warnings

Taking this review

General comments:

- Package was generated with rust2rpm and 2 patches were made
- Patches were made to exclude windows dependencies --> OK

APPROVED

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
     widestring-devel , rust-widestring+default-devel , rust-
     widestring+alloc-devel , rust-widestring+std-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: rust-widestring-devel-1.0.2-1.fc40.noarch.rpm
          rust-widestring+default-devel-1.0.2-1.fc40.noarch.rpm
          rust-widestring+alloc-devel-1.0.2-1.fc40.noarch.rpm
          rust-widestring+std-devel-1.0.2-1.fc40.noarch.rpm
          rust-widestring-1.0.2-1.fc40.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpb2i85l3g')]
checks: 31, packages: 5

rust-widestring+alloc-devel.noarch: W: no-documentation
rust-widestring+default-devel.noarch: W: no-documentation
rust-widestring+std-devel.noarch: W: no-documentation
 5 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.2 s




Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "rust-widestring+std-devel".
(none): E: there is no installed rpm "rust-widestring+default-devel".
(none): E: there is no installed rpm "rust-widestring-devel".
(none): E: there is no installed rpm "rust-widestring+alloc-devel".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 4

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s



Source checksums
----------------
https://crates.io/api/v1/crates/widestring/1.0.2/download#/widestring-1.0.2.crate :
  CHECKSUM(SHA256) this package     : 653f141f39ec16bba3c5abe400a0c60da7468261cc2cbf36805022876bc721a8
  CHECKSUM(SHA256) upstream package : 653f141f39ec16bba3c5abe400a0c60da7468261cc2cbf36805022876bc721a8


Requires
--------
rust-widestring-devel (rpmlib, GLIBC filtered):
    cargo
    rust

rust-widestring+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(widestring)
    crate(widestring/std)

rust-widestring+alloc-devel (rpmlib, GLIBC filtered):
    cargo
    crate(widestring)

rust-widestring+std-devel (rpmlib, GLIBC filtered):
    cargo
    crate(widestring)
    crate(widestring/alloc)



Provides
--------
rust-widestring-devel:
    crate(widestring)
    rust-widestring-devel

rust-widestring+default-devel:
    crate(widestring/default)
    rust-widestring+default-devel

rust-widestring+alloc-devel:
    crate(widestring/alloc)
    rust-widestring+alloc-devel

rust-widestring+std-devel:
    crate(widestring/std)
    rust-widestring+std-devel



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-widestring --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: R, SugarActivity, Python, fonts, Perl, Haskell, Java, Ocaml, C/C++, PHP
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Thanks for the review!

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-widestring

Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-ff3604323f