Bug 2241761
| Summary: | cancelling partition editing by Esc doesn't cancel, but CONFIRMS the dialog | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kamil Páral <kparal> | ||||
| Component: | blivet-gui | Assignee: | Vojtech Trefny <vtrefny> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 39 | CC: | amoloney, awilliam, fzatlouk, lruzicka, mkolman, robatino, vtrefny | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | AcceptedBlocker | ||||||
| Fixed In Version: | blivet-gui-2.4.2-4.fc39 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-10-09 22:26:05 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2143446 | ||||||
| Attachments: |
|
||||||
|
Description
Kamil Páral
2023-10-02 14:10:03 UTC
Created attachment 1991620 [details]
screencast demonstration of the bug
I don't think we want to release F39 like this. Proposing for a blocker discussion. Discussed during the 2023-10-02 blocker review meeting: [1] The decision to classify this bug as a FreezeException (Final) was made: "While we see this a bad issue, it's presence in F38 tempers our ability to make an outright decision at the moment. We do grant it FE status" [1] https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2023-10-02/f39-blocker-review.2023-10-02-16.01.log.txt Hey Vojtech, I see that this is now merged. Can you please create a blivet-gui update asap? Thanks! FEDORA-2023-e9198d932d has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e9198d932d FEDORA-2023-e9198d932d has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e9198d932d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e9198d932d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. Vojtěch, the fix looks good for all actions that I've tried. But for "Set mountpoint" action, I see "DEBUG:blivet-gui-utils:Setting mountpoint for device 'vda2'" printed in the journal, even when I hit Esc. But the actual mountpoint doesn't seem to be set, so hopefully this is just a stray debug message and it correctly cancels the action? Yes, it's just logging of the action being wrong. I have a fix for that: https://github.com/storaged-project/blivet-gui/pull/415 but I think it's not a big issue so we don't need a new build just to fix that. This works for me, and also for Kamil. Vojta confirmed that the debug line has no effect on the functionality of this fix, therefore I think we can consider this as verified. +6 / -2 in https://pagure.io/fedora-qa/blocker-review/issue/1358 , marking accepted blocker. FEDORA-2023-e9198d932d has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |