Bug 2242398

Summary:	Review Request: rust-byteyarn - Hyper-compact strings
Product:	[Fedora] Fedora	Reporter:	blinxen <h-k-81>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review?
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://crates.io/crates/byteyarn
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-10-10 18:32:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2240476

Description blinxen 2023-10-05 21:26:27 UTC

Spec URL: https://blinxen.fedorapeople.org/rust-byteyarn/rust-byteyarn.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-byteyarn/rust-byteyarn-0.2.3-1.fc40.src.rpm

Description:
Hyper-compact strings.

Fedora Account System Username: blinxen

Comment 1 Fedora Review Service 2023-10-05 21:35:19 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6494705
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2242398-rust-byteyarn/fedora-rawhide-x86_64/06494705-rust-byteyarn/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-10-05 22:26:01 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged (with explanation)
- license matches upstream specification (Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fabio Valentini 2023-10-05 22:34:07 UTC

Oh, nevermind. This package fails to build on some architectures:
https://koji.fedoraproject.org/koji/taskinfo?taskID=107107556

We will need to figure out what's happening here.

It appears that the i686 failure isn't too bad, but s390x looks concerning with all those segfaults.
Maybe the code is not properly endianness-aware?

Comment 4 blinxen 2023-10-10 18:32:39 UTC

I don't need this crate anymore because `gitoxide` does not require it anymore.
For future reference, here is the upstream issue regarding the 32-bit problem --> https://github.com/mcy/byteyarn/issues/3