Bug 2242858

Summary: Review Request: rocm-modules - A ROCm module environment
Product: [Fedora] Fedora Reporter: Tom Rix <trix>
Component: Package ReviewAssignee: Jeremy Newton <alexjnewt>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: alexjnewt, package-review, rocm-packagers-sig
Target Milestone: ---Flags: trix: fedora-review?
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
URL: https://github.com/trixirt/rocm-rpm-macros
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-10-12 18:28:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tom Rix 2023-10-09 12:18:17 UTC 
Spec URL: https://trix.fedorapeople.org/rocm-modules.spec
SRPM URL: https://trix.fedorapeople.org/rocm-modules-1.0-1.fc40.src.rpm

ROCm libraries require building all the possible AMD gpus as individual models
can have their own ISA's.  As the list of gpus grows and the code required per
gpu also grows, libraries are too large to hold all the code and must be split. An example of this rocBLAS.

These modules split the lists of gpus along family lines gfx8,gfx9,gfx10,gfx11
and a special default which is the latest two families.

And sets up gpu family specific install locations
/usr/lib64/rocm/<family>/lib,bin

Except for the default, which installs to the normal location 

Reproducible: Always
Comment 1 Fedora Review Service 2023-10-09 12:23:20 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6508190
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2242858-rocm-modules/fedora-rawhide-x86_64/06508190-rocm-modules/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 2 Jeremy Newton 2023-10-12 13:37:01 UTC 
As per RHBZ#2242859, please add this as a subpackage to rocm rpm macros if you have no objections.