Bug 2242874

Summary:	The image is no longer recognized by 'toolbox list --images', etc.
Product:	[Fedora] Fedora Container Images	Reporter:	Debarshi Ray <debarshir>
Component:	fedora-toolbox	Assignee:	Debarshi Ray <debarshir>
Status:	CLOSED WORKSFORME	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	39	CC:	debarshir, fedoraproject, gmarr, harrymichal, ogutierr, petersen, robatino, sumukher, travier
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	RejectedBlocker AcceptedFreezeException
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-10-19 10:58:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2143447, 2216766

Description Debarshi Ray 2023-10-09 14:18:46 UTC

The fedora-toolbox image for Fedora 39 and onwards is missing the com.github.containers.toolbox LABEL that used to be set in the Container/Dockerfile as:
  LABEL com.github.containers.toolbox="true"

See:
https://src.fedoraproject.org/container/fedora-toolbox/blob/f38/f/Dockerfile

It used to show up in 'podman inspect --type image ...' as:
  $ podman inspect --type image registry.fedoraproject.org/fedora-toolbox:38
          "Labels": {
            "com.github.containers.toolbox": "true",
            "license": "MIT",
            ...
            ...
            "vendor": "Fedora Project",
            "version": "38"
          }

Toolbx uses this LABEL to filter images meant to be used with Toolbx from random other OCI images.  Since, the LABEL is missing, the fedora-toolbox:39 and 40 images don't show up in 'toolbox list' and can't be removed with 'toolbox rmi'.

Comment 1 Debarshi Ray 2023-10-09 14:23:26 UTC

Pull requests:
https://pagure.io/pungi-fedora/pull-request/1199 (main)
https://pagure.io/pungi-fedora/pull-request/1200 (f39)

Comment 2 Fedora Blocker Bugs Application 2023-10-09 14:28:33 UTC

Proposed as a Blocker for 39-final by Fedora user rishi using the blocker tracking app because:

 This is a fallout from migrating the `fedora-toolbox` OCI image from being built using OpenShift Build Service from a Dockerfile to being built using Image Factory using `fedora-kickstarts` and `pungi-fedora`, as part of this Change for Fedora 39:
https://fedoraproject.org/wiki/Changes/ToolbxReleaseBlocker

It will be sad to have such a visible regression from a Change that wants to:
"... improve the quality of the containerized interactive command line Toolbx environments on Fedora by adding formal requirements to ensure that they are usable when a new Fedora is released. This will bring them closer to the reliability of similar environments running directly on the host operating system."

Comment 3 Debarshi Ray 2023-10-09 16:17:25 UTC

(In reply to Debarshi Ray from comment #1)
> Pull requests:
> https://pagure.io/pungi-fedora/pull-request/1199 (main)
> https://pagure.io/pungi-fedora/pull-request/1200 (f39)

I am currently waiting for permission to scratch build the images using Image Factory:
https://pagure.io/fedora-infrastructure/issue/11568

... but I suspect anybody who knows how to read pungi-fedora can also review their correctness.

Comment 4 Geoffrey Marr 2023-10-09 17:53:26 UTC

Discussed during the 2023-10-09 blocker review meeting: [0]

The decision to classify this bug as a "RejectedBlocker (Final)" and an "AcceptedFreezeException (Final)" was made as this does not seem to violate the criteria we put in place and probably won't affect 'typical' usage, but it would be good to have it right on release day for folks who might notice, and unblock CI.

[0] https://meetbot.fedoraproject.org/fedora-blocker-review/2023-10-09/f39-blocker-review.2023-10-09-16.00.txt

Comment 5 Jens Petersen 2023-10-19 13:29:41 UTC

I can confirm it works for me too:

petersen@localhost-live:~$ toolbox list
IMAGE ID      IMAGE NAME                                    CREATED
ff39b6cc1e44  registry.fedoraproject.org/fedora-toolbox:38  10 days ago
2cbb577df155  registry.fedoraproject.org/fedora-toolbox:39  2 days ago

Thanks!