Bug 2243052
| Summary: | Review Request: python-torchvision - A PyTorch vision package | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom Rix <trix> | ||||
| Component: | Package Review | Assignee: | Tim Flink <tflink> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | package-review, tflink | ||||
| Target Milestone: | --- | Flags: | tflink:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Linux | ||||||
| URL: | https://github.com/pytorch/vision | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-01-14 16:36:31 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1011110 | ||||||
| Attachments: |
|
||||||
|
Description
Tom Rix
2023-10-10 12:06:05 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6513712 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243052-python-torchvision/fedora-rawhide-x86_64/06513712-python-torchvision/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://trix.fedorapeople.org/python-torchvision.spec SRPM URL: https://trix.fedorapeople.org/python-torchvision-0.16.0-3.fc40.src.rpm Changed from py3_ to pyprojec_ Spec URL: https://trix.fedorapeople.org/python-torchvision.spec SRPM URL: https://trix.fedorapeople.org/python-torchvision-0.16.0-4.fc40.src.rpm - Use python-torch - enable jpeg, png, ffmpeg - Fix exec permission Copr build: https://copr.fedorainfracloud.org/coprs/build/6728863 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243052-python-torchvision/fedora-rawhide-x86_64/06728863-python-torchvision/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I have a few questions and concerns:
Where did you see BSD-2-Clause? I see Apache-2.0, BSD-3-Clause, MIT and CC-BY-NC-4.0.
CC-BY-NC-4.0 (vision_transformer model, regnet model from SWAG) is on the list of not acceptable licenses for Fedora and those files will need to be removed, which is unfortunate.
why programmatically generate part of the files? isn't %{python3_sitearch}/%{pypi_name} sufficient for this package? It doesn't cause problems, I'm mostly curious.
Spec URL: https://trix.fedorapeople.org/python-torchvision.spec SRPM URL: https://trix.fedorapeople.org/python-torchvision-0.16.0-5.fc40.src.rpm The big change is removing prebuilt torchvision/models This will resolve the CC-BY-NC-4.0 license issue and the general licensing (NO) of prebuilt models licensecheck reports BSD 2-Clause License and/or MIT License --------------------------------------- vision-0.16.0/torchvision/csrc/ops/cpu/deform_conv2d_kernel.cpp vision-0.16.0/torchvision/csrc/ops/cuda/deform_conv2d_kernel.cu I have eyeball verified that this is correct. programmatically generated part removed. Created attachment 2004610 [details]
The .spec file difference from Copr build 6728863 to 6763280
Copr build: https://copr.fedorainfracloud.org/coprs/build/6763280 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243052-python-torchvision/fedora-rawhide-x86_64/06763280-python-torchvision/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I'm not thrilled about removing all the pretrained model code but the reasoning makes sense. I'll start a conversation with Fedora legal about what we can and can't include; if it turns out that at least parts of the pretrained model code is OK, it can be added back at a later date. Otherwise LGTM The Pagure repository was created at https://src.fedoraproject.org/rpms/python-torchvision |