Bug 2243136
| Summary: | Review Request: kf6-kio - KDE Frameworks 6 Tier 3 solution for filesystem abstraction | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Cossette <farchord> | ||||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | alekcejk, ngompa13, package-review | ||||||
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| URL: | https://invent.kde.org/frameworks/%{framework} | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2023-10-11 20:19:07 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 2235556, 2243407, 2243418, 2243435 | ||||||||
| Attachments: |
|
||||||||
|
Description
Steve Cossette
2023-10-10 22:13:18 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6514888 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243136-kf6-kio/fedora-rawhide-x86_64/06514888-kf6-kio/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this review. Initial spec review: > Requires: switcheroo-control This needs to be on the core subpackage. > ## org.kde.klauncher5 service referenced from : widgets/krun.cpp > ## included here for completeness, even those -core already has a dependency. > %{?kf6_kinit_requires} The comment should be updated to mention klauncher6. > ## omitted since 5.45, security concerns? -- rex > %if 0 > # file_helper > %{_kf6_sysconfdir}/dbus-1/system.d/org.kde.kio.file.conf > %{_kf6_libexecdir}/kauth/file_helper > %{_kf6_datadir}/dbus-1/system-services/org.kde.kio.file.service > %{_kf6_datadir}/polkit-1/actions/org.kde.kio.file.policy > %endif Is this still unavailable? If so, then we should just drop this section entirely... Spec URL: https://farchord.fedorapeople.org/reviews/kf6-kio/kf6-kio.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-kio/kf6-kio-5.240.0^20231010.060359.1c34fd4-1.fc39.src.rpm Updated all the suggested things Created attachment 1993363 [details]
The .spec file difference from Copr build 6514888 to 6514960
Copr build: https://copr.fedorainfracloud.org/coprs/build/6514960 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243136-kf6-kio/fedora-rawhide-x86_64/06514960-kf6-kio/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] > ## omitted since 5.45, security concerns? -- rex
> #%%if 0
> # file_helper
> #%%{_kf6_sysconfdir}/dbus-1/system.d/org.kde.kio.file.conf
> #%%{_kf6_libexecdir}/kauth/file_helper
> #%%{_kf6_datadir}/dbus-1/system-services/org.kde.kio.file.service
> #%%{_kf6_datadir}/polkit-1/actions/org.kde.kio.file.policy
> #%%endif
I wanted this deleted, not commented out. It already doesn't do anything.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6516782 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243136-kf6-kio/fedora-rawhide-x86_64/06516782-kf6-kio/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://farchord.fedorapeople.org/reviews/kf6-kio/kf6-kio.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-kio/kf6-kio-5.240.0^20231010.060359.1c34fd4-1.fc39.src.rpm Require'd a noarch package as an arch'd package by mistake, fixed. Created attachment 1993529 [details]
The .spec file difference from Copr build 6516782 to 6517532
Copr build: https://copr.fedorainfracloud.org/coprs/build/6517532 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243136-kf6-kio/fedora-rawhide-x86_64/06517532-kf6-kio/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint Note: it looks like k6-filesystem requires needs to move to core subpackage to resolve the unowned directories issue. Please fix that on import. PACKAGE APPROVED. Thank you for the review, Neal https://pagure.io/releng/fedora-scm-requests/issue/56967 The Pagure repository was created at https://src.fedoraproject.org/rpms/kf6-kio Thank you, moved the require to the core subpackage. Why kf6-kio-widgets requires kf6-kio-devel?
# rpm -e kf6-kio-devel
error: Failed dependencies:
libkuriikwsfiltereng_private.so()(64bit) is needed by (installed) kf6-kio-widgets-5.245.0-1.fc40.x86_64
|