Bug 2243298

Summary: Review Request: rust-unic-ucd-normal - UNIC — Unicode Character Database — Normalization Properties
Product: [Fedora] Fedora Reporter: blinxen <h-k-81>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-10-14 18:46:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description blinxen 2023-10-11 16:28:03 UTC
Spec URL: https://blinxen.fedorapeople.org/rust-unic-ucd-normal/rust-unic-ucd-normal.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-unic-ucd-normal/rust-unic-ucd-normal-0.9.0-1.fc40.src.rpm

Description:
UNIC — Unicode Character Database — Normalization Properties.

Fedora Account System Username: blinxen

Comment 1 blinxen 2023-10-11 16:28:06 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=107366114

Comment 2 Fabio Valentini 2023-10-13 22:22:48 UTC
> # FIXME: no license files detected

Please address this, it's the same issue as in the other rust-unic-ucd* crates.

Comment 4 Fabio Valentini 2023-10-14 16:56:33 UTC
Thanks, looks good now.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files (included manually from upstream)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Also looks like the rust-unic project is dead upstream :( No activity in three years.
Maybe dependent projects should move to an alternative, given that new unicode standards won't be implemented in these crates?

Comment 5 Fedora Admin user for bugzilla script actions 2023-10-14 18:27:58 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-unic-ucd-normal

Comment 6 blinxen 2023-10-14 18:31:40 UTC
> Maybe dependent projects should move to an alternative, given that new unicode standards won't be implemented in these crates?

I packaged this crate for helix and it is a dependency of a dependency (`chardetng`). `chardetng` is used to detect legacy encoding in files. It is only used once in the whole code base. So replacing it should be trivial. However finding an alternative for it is a bit difficult :/.

Comment 7 Fedora Update System 2023-10-14 18:44:41 UTC
FEDORA-2023-ab7a4c7044 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ab7a4c7044

Comment 8 Fedora Update System 2023-10-14 18:46:11 UTC
FEDORA-2023-ab7a4c7044 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.