Bug 2243766
| Summary: | Review Request: kf6-frameworkintegration - KDE Frameworks 6 Tier 4 workspace and cross-framework integration plugins | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Cossette <farchord> | ||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Neal Gompa <ngompa13> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | ngompa13, package-review | ||||
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://invent.kde.org/frameworks/%{framework} | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-10-13 17:03:42 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2235556 | ||||||
| Attachments: |
|
||||||
|
Description
Steve Cossette
2023-10-13 00:06:51 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6521481 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243766-kf6-frameworkintegration/fedora-rawhide-x86_64/06521481-kf6-frameworkintegration/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this review. > BuildRequires: cmake(AppStreamQt) This requires >= 1.0 > BuildRequires: PackageKit-Qt6-devel This should be "cmake(packagekitqt6)" Spec URL: https://farchord.fedorapeople.org/reviews/kf6-frameworkintegration/kf6-frameworkintegration.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-frameworkintegration/kf6-frameworkintegration-5.240.0^20231003.064310.c062482-1.fc39.src.rpm Temporarily disabled appstreamqt (Will be enabled once v1.0 is in Fedora) Spec URL: https://farchord.fedorapeople.org/reviews/kf6-frameworkintegration/kf6-frameworkintegration.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kf6-frameworkintegration/kf6-frameworkintegration-5.240.0^20231003.064310.c062482-1.fc39.src.rpm Updated version requirement of appstreamqt, and changed packagekit to use the cmake package name Copr build: https://copr.fedorainfracloud.org/coprs/build/6522984 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243766-kf6-frameworkintegration/fedora-rawhide-x86_64/06522984-kf6-frameworkintegration/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Created attachment 1993728 [details]
The .spec file difference from Copr build 6522984 to 6522996
Copr build: https://copr.fedorainfracloud.org/coprs/build/6522996 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243766-kf6-frameworkintegration/fedora-rawhide-x86_64/06522996-kf6-frameworkintegration/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint PACKAGE APPROVED. Thank you for the review, Neal https://pagure.io/releng/fedora-scm-requests/issue/57002 The Pagure repository was created at https://src.fedoraproject.org/rpms/kf6-frameworkintegration |