Bug 2244428

Summary: Review Request: rpm-local-generator-support - RPM local_generator support
Product: [Fedora] Fedora Reporter: Vít Ondruch <vondruch>
Component: Package ReviewAssignee: Miroslav Suchý <msuchy>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mhroncok, msuchy, package-review
Target Milestone: ---Flags: msuchy: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: rpm-local-generator-support-1-1.fc40 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-10-18 10:24:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vít Ondruch 2023-10-16 14:12:06 UTC 
Spec URL: https://fedorapeople.org/cgit/vondruch/public_git/rpm-local-generator-support.git/plain/rpm-local-generator-support.spec?id=469fcda122c5856dc10bae4cb75daee0cdf61d15
SRPM URL: https://people.redhat.com/vondruch/rpm-local-generator-support-1-1.fc40.src.rpm
Description: local_generator.attr file enabling RPM dependency generator to be used on .spec files, which ships them.

Fedora Account System Username: vondruch


Please note that this RPM supports my idea described in more detail here:

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/3MHROKOM53HM6NF7RGGLFBIQFG5IEIQG/
Comment 1 Vít Ondruch 2023-10-16 14:12:56 UTC 
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=107593752
Comment 2 Miroslav Suchý 2023-10-16 14:34:26 UTC 
The package cannot be simpler, but it can be better. :)

> Release:1%{?dist}

Please add space after :

> License: MIT

The guidelines say:
If the source package does not include the text of the license(s), the packager should contact upstream and encourage them to correct this mistake.

And because you are the upstream, you should be encouraged to include the license text. Likely as SourceX.

But none of the things above justify blocking the review.

APPROVED
Comment 3 Vít Ondruch 2023-10-16 14:44:42 UTC 
(In reply to Miroslav Suchý from comment #2)
> The package cannot be simpler, but it can be better. :)
> 
> > Release:1%{?dist}

Good catch

> Please add space after :
> 
> > License: MIT
> 
> The guidelines say:
> If the source package does not include the text of the license(s), the
> packager should contact upstream and encourage them to correct this mistake.
> 
> And because you are the upstream, you should be encouraged to include the
> license text. Likely as SourceX.

Thx for contacting me ;) I was kind of thinking about omitting the license, because .spec are MIT by default, aren't they? And actually, I don't know if the empty file is even licensable/copyrightable?

> But none of the things above justify blocking the review.
> 
> APPROVED

Thx a lot.
Comment 4 Fedora Admin user for bugzilla script actions 2023-10-16 14:52:00 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/rpm-local-generator-support
Comment 5 Miro Hrončok 2023-10-17 20:37:15 UTC 
Should this either depend on rpm or co-own %{_fileattrsdir}?

----

> The package can't be simpler. 

%autorelease maybe? :D
Comment 6 Vít Ondruch 2023-10-18 10:24:23 UTC 
(In reply to Miro Hrončok from comment #5)
> Should this either depend on rpm or co-own %{_fileattrsdir}?

Good question! Looking for prior art, it seems that the ownership or dependency on RPM are not standard. But we could have generator for the RPM dependency!

 
> ----
> 
> > The package can't be simpler. 
> 
> %autorelease maybe? :D

There are some gaps.