Bug 2244862

Summary:	Failure to build python-torch
Product:	[Fedora] Fedora	Reporter:	Tom Rix <trix>
Component:	pyproject-rpm-macros	Assignee:	Miro Hrončok <mhroncok>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	maxwell, mhroncok, pviktori, python-packagers-sig
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-10-18 16:48:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tom Rix 2023-10-18 15:50:38 UTC

From the package review of python-torch
https://bugzilla.redhat.com/show_bug.cgi?id=2242971

reproduce with

mock --with pyproject ~/rpmbuild/SRPMS/python-torch-2.1.0-5.fc40.src.rpm 

and get this failure

+ /usr/bin/python3 -Bs /usr/lib/rpm/redhat/pyproject_wheel.py /builddir/build/BUILD/pytorch-v2.1.0/pyproject-wheeldir
/usr/bin/python3: No module named pip



Reproducible: Always

Comment 1 Miro Hrončok 2023-10-18 16:48:56 UTC

Using %pyproject_wheel without %pyproject_buildrequires is not supported. If you do that, you need to specify all build dependencies (including pip) manually. And you need to be prepared that they might change in the future.

Let me figure out why you think %pyproject_buildrequires is broken in bz2242971.

Comment 2 Tom Rix 2023-10-18 17:01:26 UTC

the %project_buildrequires could not resolve python-cmake,ninja the ones it could have been added manually