Bug 2244871

Summary:	Review Request: rust-detone - Decompose Vietnamese tone marks
Product:	[Fedora] Fedora	Reporter:	blinxen <h-k-81>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-10-19 16:52:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description blinxen 2023-10-18 16:56:34 UTC

Spec URL: https://blinxen.fedorapeople.org/rust-detone/rust-detone.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-detone/rust-detone-1.0.0-1.fc40.src.rpm

Description:
Decompose Vietnamese tone marks.

Fedora Account System Username: blinxen

Comment 1 blinxen 2023-10-18 16:56:37 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=107716668

Comment 2 Fedora Review Service 2023-10-18 16:57:30 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6544269
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244871-rust-detone/srpm-builds/06544269/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2023-10-19 14:15:04 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fedora Admin user for bugzilla script actions 2023-10-19 16:33:34 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-detone

Comment 5 Fedora Update System 2023-10-19 16:49:05 UTC

FEDORA-2023-b54e8fb16e has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b54e8fb16e

Comment 6 Fedora Update System 2023-10-19 16:52:11 UTC

FEDORA-2023-b54e8fb16e has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.