Bug 2245085

Summary: [CephFS - Snapshot] Snapshot schedule for subvolume with option --subvol fails with unexpected argument error
Product: [Red Hat Storage] Red Hat Ceph Storage Reporter: sumr
Component: CephFSAssignee: Milind Changire <mchangir>
Status: CLOSED ERRATA QA Contact: sumr
Severity: high Docs Contact: Disha Walvekar <dwalveka>
Priority: unspecified    
Version: 7.0CC: amk, ceph-eng-bugs, cephqe-warriors, dwalveka, gfarnum, hyelloji, mchangir, ngangadh, sumr, tserlin, vshankar
Target Milestone: ---   
Target Release: 7.0z2   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: ceph-18.2.0-176.el9cp Doc Type: Enhancement
Doc Text:
This effort adds support to help users schedule snapshots for subvolumes in default as well as non-default subvolume groups.
 Story Points: ---
Clone Of:
: 2253351 (view as bug list) Environment:
Last Closed: 2024-05-07 12:10:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2253351, 2253352, 2270485    

Description sumr 2023-10-19 15:43:34 UTC 
Description of problem:
snap-schedule creation for subvolume is supported, but in recent ceph build on 7.0 RHCS cluster we see an invalid argument error when option --subvol is used.

ceph fs snap-schedule add /.. 1h --fs cephfs --subvol subvolume_default_1
Invalid command: Unexpected argument '--subvol'
fs snap-schedule add <path> <snap_schedule> [<start>] [<fs>] :  Set a snapshot schedule for <path>
Error EINVAL: invalid command


Version-Release number of selected component (if applicable):


How reproducible: Consistent


Steps to Reproduce:
1.Create subvolume in default subvolumegroup
2. Enable snap-schedule. Add snap-schedule for subvolume as below,
ceph fs snap-schedule add . 1h --fs cephfs --subvol subvolume_default_1


Actual results:
snap-schedule add fails with error,
 "Invalid command: Unexpected argument '--subvol'
fs snap-schedule add <path> <snap_schedule> [<start>] [<fs>] :  Set a snapshot schedule for <path>
Error EINVAL: invalid command"

Expected results: subvol option should work.


Additional info:
ceph version 18.2.0-72.el9cp (3f281315a9c7d4bb2281729a5f3c3366ad99193d) reef (stable)
Comment 1 sumr 2023-10-19 15:50:29 UTC 
Additional details from offline discussion with Dev team,

this is a regression
DOWNSTREAM ONLY patches that were committed for snap-schedule for 17.x.x haven't been applied to downstream 18.2.x

Milind Changire, 5:26 PM
appropriate MR has been posted - https://gitlab.cee.redhat.com/ceph/ceph/-/merge_requests/404
Comment 2 sumr 2023-10-31 05:12:47 UTC 
Hi Milind, 

Can you please update the status of this bug?

Thanks,
Suma
Comment 5 Venky Shankar 2024-03-29 12:16:36 UTC 
*** Bug 2253352 has been marked as a duplicate of this bug. ***
Comment 13 Amarnath 2024-04-16 05:58:27 UTC 
Hi Milind,

Could you please confirm if this BZ needs to be added to the 7.0z2 release notes? If so, please provide the doc type and the doc text.

Regards,
Amarnath
Comment 15 errata-xmlrpc 2024-05-07 12:10:00 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat Ceph Storage 7.0 Bug Fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2024:2743