Bug 2245299
| Summary: | Review Request: gpgme1.22 - GnuPG Made Easy - high level crypto API - version 1.22 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Troy Dawson <tdawson> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | maxwell, ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://gnupg.org/related_software/gpgme/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-10-24 01:02:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Troy Dawson
2023-10-20 16:07:50 UTC
Note: This is for EPEL9 only. This package is from the current Fedora Rawhide (F40) gpgme. The changes are minimal. There was no change to the build. Only to the naming and what goes into packages. There are no runtime conflicts with any other packages. There are -devel conflicts with what is in RHEL 9. The policy of conflicting -devel packages was discussed and approved by the EPEL Steering Committee. I picked that version because it should be in RHEL 10. Thus it should have a longer lifetime of support. Copr build: https://copr.fedorainfracloud.org/coprs/build/6552057 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2245299-gpgme1.22/fedora-rawhide-x86_64/06552057-gpgme1.22/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint Nit: I would prefer to see the subpackage definitions for everything not being shipped to be fully erased. That makes it more obvious that some subpackages aren't being shipped (e.g. python3-gpg). PACKAGE APPROVED. > Nit: I would prefer to see the subpackage definitions for everything not being shipped to be fully erased. That makes it more obvious that some subpackages aren't being shipped (e.g. python3-gpg).
Can we build gpgme out of this specfile for python3.11 (the subpackage would be named python3.11-gpg instead)? This way, it wouldn't conflict with RHEL, but packages that need a new version could use that one and build for python3.11.
I would be okay with that too. The Pagure repository was created at https://src.fedoraproject.org/rpms/gpgme1.22 I will update the spec to do the python3.11 mentioned, double check the build, and if it builds ok and doesn't conflict (which it shouldn't) I'll use that as the first build. FEDORA-EPEL-2023-5a7d70d01b has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-5a7d70d01b It looks really good. Thanks for the review. I also noticed that I had turned off testing (so my test builds went faster). I have turned testing back on, along with the python3.11 stuff. FEDORA-EPEL-2023-5a7d70d01b has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. |