Bug 2245476
| Summary: | Review Request: rust-gst-plugin-gif - GStreamer GIF plugin | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Artem <ego.cordatus> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ego.cordatus, package-review |
| Target Milestone: | --- | Flags: | ego.cordatus:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-10-22 14:22:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabio Valentini
2023-10-21 22:12:47 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=107900821 This could be ignored? I've noticed this happens for all rust packages which generated by rust2rpm: Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/gst-plugin- gif-0.11.0/LICENSE-APACHE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files --- Why removing? If someone project will require it during build i'ts it's better to use unified PKG-CONFIG instead of distro packaged names. Or this scenario not possible with rust-gst-plugin-gif since nothing to link here? > # remove unnecessary pkgconfig file > rm -v %{buildroot}/%{_libdir}/pkgconfig/gstgif.pc (In reply to Artem from comment #2) > This could be ignored? I've noticed this happens for all rust packages which > generated by rust2rpm: > > Issues: > ======= > - Package does not contain duplicates in %files. > Note: warning: File listed twice: /usr/share/cargo/registry/gst-plugin- > gif-0.11.0/LICENSE-APACHE > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_duplicate_files Yes, this is a warning that can be ignored. The resulting package contains the correct files and %doc files marked appropriately. I have confirmation from RPM upstream that this is an acceptable workaround for limitations of RPM itself. > --- > > Why removing? If someone project will require it during build i'ts it's > better to use unified PKG-CONFIG instead of distro packaged names. Or this > scenario not possible with rust-gst-plugin-gif since nothing to link here? > > > # remove unnecessary pkgconfig file > > rm -v %{buildroot}/%{_libdir}/pkgconfig/gstgif.pc Hm, we have removed these in the other gstreamer-rs plugins as well. I don't think they are useful, since you can't link to this plugin, and there are no generated header files, either. As far as I can tell, the .pc file is just automatically generated by "cargo cinstall", even if it's not needed. Package was generated with rust2rpm, simplifying the review. - Package builds and installs without errors on rawhide ! missing test dev-dependency: gstreamer-check ^0.21. Could packaged later. - Latest version of the crate is packaged - License matches upstream specification (MIT) and is acceptable for Fedora - License file is included with %license in %files - Package complies with Rust Packaging Guidelines - Builds in Mock - No rpmlint errors Package APPROVED. Thanks for the review! The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gst-plugin-gif FEDORA-2023-f1178b012a has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f1178b012a FEDORA-2023-f1178b012a has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |