Bug 2245598
| Summary: | libsigrokdecode fails to build with Python 3.13: error: implicit declaration of function ‘PyEval_InitThreads’ | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Karolina Surma <ksurma> |
| Component: | libsigrokdecode | Assignee: | Alex G. <mr.nuke.me> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 40 | CC: | ksurma, mhroncok, mr.nuke.me |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-04-19 02:00:07 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2244836 | ||
|
Description
Karolina Surma
2023-10-23 08:57:10 UTC
srd.c: In function ‘srd_init’:
srd.c:281:9: error: implicit declaration of function ‘PyEval_InitThreads’; did you mean ‘PyEval_SaveThread’? [-Werror=implicit-function-declaration]
281 | PyEval_InitThreads();
| ^~~~~~~~~~~~~~~~~~
| PyEval_SaveThread
According to https://docs.python.org/3.13/whatsnew/3.13.html
Remove PyEval_InitThreads() and PyEval_ThreadsInitialized() functions, deprecated in Python 3.9. Since Python 3.7, Py_Initialize() always creates the GIL: calling PyEval_InitThreads() did nothing and PyEval_ThreadsInitialized() always returned non-zero. (Contributed by Victor Stinner in https://github.com/python/cpython/issues/105182.)
From looking at upstream's configure.ac, they haven't yet implemented Python 3.13 support. The last change was in April 2023, to add Python 3.12 support. We could try removing the problematic calls in Fedora's version, but I think it's better to contact upstream and have them come up with a generic fix. Upstream has fixed the issue in commit 0c35c5c ("srd: drop deprecated PyEval_InitThreads() on Python 3.9+").
I was trying to test this in a mock build, following the instructions from https://copr.fedorainfracloud.org/coprs/g/python/python3.13/ . However, mock consistently fails with:
Public key for <some-package>.rpm is not installed. Failing package is: zstd-1.5.5-4.fc39.x86_64
GPG Keys are configured as: file:///usr/share/distribution-gpg-keys/fedora/RPM-GPG-KEY-fedora-39-primary, file:///usr/share/distribution-gpg-keys/fedora/RPM-GPG-KEY-fedora-39-primary, file:///usr/share/distribution-gpg-keys/fedora/RPM-GPG-KEY-fedora-38-primary
Error: GPG check FAILED
How do I get past this?
Do you have up-to-date mock, mock-core-config, mock-core-configs, distribution-gpg-keys? Updating the aforementioned packages solved the issue. Thank you! I pushed upstrean's fix to https://src.fedoraproject.org/rpms/libsigrokdecode/c/e77894683a529eb7ec1b405c9106f0f1bbf6152a?branch=rawhide This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle. Changing version to 40. |