Bug 2245796

Summary: pyotherside fails to build with Python 3.13: error: ‘PyEval_InitThreads’, 'PySys_SetArgvEx' was not declared in this scope
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: pyothersideAssignee: Martin Kolman <mkolman>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 40CC: ksurma, mhroncok, mkolman, orion
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pyotherside-1.6.1-1.fc39 pyotherside-1.6.1-1.fc40 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-08 01:53:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2244836    

Description Karolina Surma 2023-10-24 07:50:28 UTC
pyotherside fails to build with Python 3.13.0a1.

qpython_priv.cpp: In constructor QPythonPriv::QPythonPriv():
qpython_priv.cpp:518:5: error: ‘PyEval_InitThreads’ was not declared in this scope; did you mean ‘PyEval_SaveThread’?
  518 |     PyEval_InitThreads();
      |     ^~~~~~~~~~~~~~~~~~
      |     PyEval_SaveThread

qpython_priv.cpp:524:5: error: PySys_SetArgvEx was not declared in this scope
  524 |     PySys_SetArgvEx(argc, argv, 0);
      |     ^~~~~~~~~~~~~~~

According to https://docs.python.org/3.13/whatsnew/3.13.html:

- Remove PyEval_InitThreads() and PyEval_ThreadsInitialized() functions, deprecated in Python 3.9. Since Python 3.7, Py_Initialize() always creates the GIL:
calling PyEval_InitThreads() did nothing and PyEval_ThreadsInitialized() always returned non-zero.
(Contributed by Victor Stinner in https://github.com/python/cpython/issues/105182.)
- Remove PySys_SetArgvEx(): set PyConfig.argv instead.

https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06546758-pyotherside/

For all our attempts to build pyotherside with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/pyotherside/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Aoife Moloney 2024-02-15 23:00:48 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle.
Changing version to 40.

Comment 2 Fedora Update System 2024-06-29 10:55:19 UTC
FEDORA-2024-f563337283 (pyotherside-1.6.1-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f563337283

Comment 3 Fedora Update System 2024-06-29 10:56:06 UTC
FEDORA-2024-259b757f03 (pyotherside-1.6.1-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-259b757f03

Comment 4 Fedora Update System 2024-06-30 02:26:53 UTC
FEDORA-2024-f563337283 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f563337283`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f563337283

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2024-06-30 05:33:42 UTC
FEDORA-2024-259b757f03 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-259b757f03`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-259b757f03

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2024-07-08 01:53:51 UTC
FEDORA-2024-259b757f03 (pyotherside-1.6.1-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-07-08 01:56:48 UTC
FEDORA-2024-f563337283 (pyotherside-1.6.1-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.