Bug 2245801

Summary: python-zodbpickle fails to build with Python 3.13: error: implicit declaration of function ‘_Py_IDENTIFIER‘
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: python-zodbpickleAssignee: Jerry James <loganjerry>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 40CC: ksurma, loganjerry, mhroncok, vstinner
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-zodbpickle-3.2-1.fc41 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-02-16 16:30:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2244836    

Description Karolina Surma 2023-10-24 07:55:50 UTC
python-zodbpickle fails to build with Python 3.13.0a1.

src/zodbpickle/_pickle_33.c:38:14: error: implicit declaration of function _PyObject_LookupAttrId did you mean _PyObject_HasAttrId? [-Werror=implicit-function-declaration]
     38 |     result = _PyObject_LookupAttrId(obj, id, &attr_val);
        |              ^~~~~~~~~~~~~~~~~~~~~~
        |              _PyObject_HasAttrId


src/zodbpickle/_pickle_33.c:875:5: error: implicit declaration of function ‘_Py_IDENTIFIER’ [-Werror=implicit-function-declaration]
    875 |     _Py_IDENTIFIER(write);
        |     ^~~~~~~~~~~~~~

- _Py_IDENTIFIER has been removed from Python 3.13.
The detailed list of the removed private C API functions can be found here:
https://github.com/python/cpython/issues/106320


https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06560418-python-zodbpickle/

For all our attempts to build python-zodbpickle with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/python-zodbpickle/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Jerry James 2023-10-24 15:48:12 UTC
What are Python extensions supposed to use in place of _PyObject_GetAttrId, _PyObject_HasAttrId, and _PyObject_CallMethodId?  I looked at https://github.com/python/cpython/pull/108593, but the answer is not obvious to me.

Comment 2 Karolina Surma 2023-10-25 09:00:38 UTC
Victor, could you provide some pointers?

Comment 3 Victor Stinner 2023-10-30 10:45:56 UTC
> Victor, could you provide some pointers?

I created an upstream issue to discuss _Py_IDENTIFIER removal: https://github.com/python/cpython/issues/111484

Comment 4 Aoife Moloney 2024-02-15 23:00:55 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle.
Changing version to 40.

Comment 5 Jerry James 2024-02-16 16:30:18 UTC
Version 3.2 was released with support for python 3.13a3.  Python 3.13a4 broke this package again, by adding an argument to _PyLong_AsByteArray, but I added a patch to fix that.  The patched version 3.2 has been built in Rawhide.

Comment 6 Karolina Surma 2024-02-16 16:39:05 UTC
Thank you! It built successfully in the test Copr too.