Bug 2245804

Summary: lldb fails to build with Python 3.13: error: implicit declaration of function ‘PyEval_InitThreads’
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: lldbAssignee: Tulio Magno Quites Machado Filho <tuliom>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: airlied, jan, jchecahi, kkleine, ksurma, mhroncok, npopov, sergesanspaille, siddharth.kde, tstellar, tuliom
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-11-30 18:17:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2244836    

Description Karolina Surma 2023-10-24 08:02:44 UTC
lldb fails to build with Python 3.13.0a1.

/builddir/build/BUILD/lldb-17.0.3.src/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:191:5: error: use of undeclared identifier 'PyEval_InitThreads'; did you mean 'PyEval_SaveThread'?
  191 |     PyEval_InitThreads();
      |     ^~~~~~~~~~~~~~~~~~
      |     PyEval_SaveThread

According to https://docs.python.org/3.13/whatsnew/3.13.html:

Remove PyEval_InitThreads() and PyEval_ThreadsInitialized() functions, deprecated in Python 3.9.
Since Python 3.7, Py_Initialize() always creates the GIL:
calling PyEval_InitThreads() did nothing and PyEval_ThreadsInitialized() always returned non-zero.
(Contributed by Victor Stinner in https://github.com/python/cpython/issues/105182.)


https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06560401-lldb/

For all our attempts to build lldb with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/lldb/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Tulio Magno Quites Machado Filho 2023-10-26 17:41:53 UTC
This will require some work upstream.

We first need to convert test code to Python 3.12.
I'm working on this.

Comment 2 Tulio Magno Quites Machado Filho 2023-10-27 20:09:27 UTC
I have proposed 2 fixes upstream:
https://github.com/llvm/llvm-project/pull/70443
https://github.com/llvm/llvm-project/pull/70445

They're under review.

I have also reported an issue that may require further changes in order to be fully compatible with Python >= 3.12:
https://github.com/llvm/llvm-project/issues/70453

And I created a PR downstream at:
https://src.fedoraproject.org/rpms/lldb/pull-request/63

Comment 3 Tulio Magno Quites Machado Filho 2023-11-30 18:17:49 UTC
The 2 fixes I proposed upstream got merged.
I backported them to Rawhide. Future lldb builds should work now.

The remaining issue will automatically be integrated in Fedora when upstream fixes it.

With that said, I'm closing this bug report.