Bug 2246142

Summary: python-immutables fails to build with Python 3.13: multiple unknown names: ‘_PyUnicodeWriter’, ‘_PyUnicodeWriter_Init’, ‘_map_dump_format’, ‘map_node_dump’, ‘_PyUnicodeWriter_Finish’, ‘_PyUnicodeWriter_Dealloc’, ‘_PyUnicodeWriter_WriteASCIIString’
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: python-immutablesAssignee: Carl George 🎩 <carl>
Status: CLOSED ERRATA QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: carl, code, ksurma, mhroncok, python-packagers-sig
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-immutables-0.20-5.fc41 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-06-06 16:05:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2244836    

Description Karolina Surma 2023-10-25 14:51:25 UTC
python-immutables fails to build with Python 3.13.0a1.

This report is automated and not very verbose, but we'll try to get back here with details.

  immutables/_map.c:372:15: error: unknown type name ‘_PyUnicodeWriter’; did you mean ‘PyUnicode_WRITE’?
    372 |               _PyUnicodeWriter *writer, int level);
        |               ^~~~~~~~~~~~~~~~
        |               PyUnicode_WRITE
  immutables/_map.c:2614:5: error: implicit declaration of function ‘_PyUnicodeWriter_Init’ [-Werror=implicit-function-declaration]
   2614 |     _PyUnicodeWriter_Init(&writer);
        |     ^~~~~~~~~~~~~~~~~~~~~
  immutables/_map.c:2616:9: error: implicit declaration of function ‘_map_dump_format’ [-Werror=implicit-function-declaration]
   2616 |     if (_map_dump_format(&writer, "HAMT(len=%zd):\n", self->h_count)) {
        |         ^~~~~~~~~~~~~~~~
  immutables/_map.c:2620:9: error: implicit declaration of function ‘map_node_dump’; did you mean ‘map_node_find’? [-Werror=implicit-function-declaration]
   2620 |     if (map_node_dump(self->h_root, &writer, 0)) {
        |         ^~~~~~~~~~~~~
        |         map_node_find
  immutables/_map.c:2624:12: error: implicit declaration of function ‘_PyUnicodeWriter_Finish’ [-Werror=implicit-function-declaration]
   2624 |     return _PyUnicodeWriter_Finish(&writer);
        |            ^~~~~~~~~~~~~~~~~~~~~~~
  immutables/_map.c:2627:5: error: implicit declaration of function ‘_PyUnicodeWriter_Dealloc’ [-Werror=implicit-function-declaration]
   2627 |     _PyUnicodeWriter_Dealloc(&writer);
        |     ^~~~~~~~~~~~~~~~~~~~~~~~
  immutables/_map.c:3196:13: error: implicit declaration of function ‘_PyUnicodeWriter_WriteASCIIString’; did you mean ‘PyUnicode_CompareWithASCIIString’? [-Werror=implicit-function-declaration]
   3196 |         if (_PyUnicodeWriter_WriteASCIIString(
        |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        |             PyUnicode_CompareWithASCIIString
  immutables/_map.c:3230:17: error: implicit declaration of function ‘_PyUnicodeWriter_WriteStr’ [-Werror=implicit-function-declaration]
   3230 |             if (_PyUnicodeWriter_WriteStr(&writer, s) < 0) {
        |                 ^~~~~~~~~~~~~~~~~~~~~~~~~

https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06546790-python-immutables/

For all our attempts to build python-immutables with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/python-immutables/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Aoife Moloney 2024-02-15 23:01:58 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle.
Changing version to 40.

Comment 2 Carl George 🎩 2024-06-05 15:38:03 UTC
Python 3.13 is planned for F41, so switching this back to rawhide for now.

https://fedoraproject.org/wiki/Changes/Python3.13

This is still failing with Python 3.13.0b1.

https://github.com/MagicStack/immutables/issues/116

Comment 3 Ben Beasley 2024-06-05 16:46:54 UTC
I offered a fix for this upstream, https://github.com/MagicStack/immutables/pull/118, and a PR to apply it as a patch downstream: https://src.fedoraproject.org/rpms/python-immutables/pull-request/3

Comment 4 Carl George 🎩 2024-06-06 03:07:40 UTC
Thanks Ben.  I'm fine merging this now, or we can give upstream some time to comment on the PR first if you like.

Comment 5 Fedora Update System 2024-06-06 15:52:24 UTC
FEDORA-2024-6871c39b3d (python-immutables-0.20-5.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6871c39b3d

Comment 6 Fedora Update System 2024-06-06 16:05:34 UTC
FEDORA-2024-6871c39b3d (python-immutables-0.20-5.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.