Bug 224684
Summary: | Review Request: cronolog - Web log rotation program for Apache | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | jafo-redhat |
Component: | Package Review | Assignee: | Ville Skyttä <ville.skytta> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | jkeating:
fedora-cvs+
|
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-02-11 19:00:26 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
jafo-redhat
2007-01-27 00:10:31 UTC
- "strip src/cronolog" needs to go, let rpmbuild take care of it and produce a usable debuginfo package. - Use "make install DESTDIR=..." instead of %makeinstall http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002 - Why is the info file removed instead of being included and properly installed? http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#info - The man page refers to /www/sbin/cronolog which could be replaced by the actual installation path, /usr/sbin/cronolog - Would /usr/bin be a more appropriate install path for cronosplit than /usr/sbin? - INSTALL is useless in %doc, and should be dropped. All these items addressed, thanks. ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/cronolog-1.6.2-4.src.rpm ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/cronolog.spec Looks good, approved. New Package CVS Request ======================= Package Name: cronolog Short Description: Web log rotation program for Apache Owners: jafo Branches: EL-5 InitialCC: Branch 'EL-5' created for module 'cronolog' from branch 'FC-6' I assume this was a branch request since the module already existed. Please use the proper request form next time. |