Bug 2247039

Summary: jc fails to build with Python 3.13: AssertionError: {'ver[45 chars]ffff:192.168.1.35', 'ip_compressed': '::ffff:1[2371 chars]11'}} != {'ver[45 chars]ffff:c0a8:123', 'ip_compressed': '::ffff:c0a8:[2336 chars]11'}}
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: jcAssignee: Artur Frenszek-Iwicki <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 41CC: awilliam, blaise, djasa, fedora, fti-bugs, ksurma, mhroncok, michel
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: AcceptedFreezeException
Fixed In Version: jc-1.25.3-4.fc41 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-09-11 18:21:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2260875, 2260877, 2244836, 2247866    

Description Karolina Surma 2023-10-30 12:41:22 UTC
jc fails to build with Python 3.13.0a1.

This report is automated and not very verbose, but we'll try to get back here with details.

FAIL: test_ip_address_ipv6_ipv4_mapped (tests.test_ip_address.MyTests.test_ip_address_ipv6_ipv4_mapped)
Test ipv6 address with ipv4 mapped string
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/jc-1.23.6/tests/test_ip_address.py", line 93, in test_ip_address_ipv6_ipv4_mapped
    self.assertEqual(jc.parsers.ip_address.parse(data, quiet=True), expected)
AssertionError: {'ver[45 chars]ffff:192.168.1.35', 'ip_compressed': '::ffff:1[2371 chars]11'}} != {'ver[45 chars]ffff:c0a8:123', 'ip_compressed': '::ffff:c0a8:[2336 chars]11'}}
Diff is 3874 characters long. Set self.maxDiff to None to see it.

https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06578995-jc/

For all our attempts to build jc with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/jc/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Aoife Moloney 2024-02-15 23:02:55 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle.
Changing version to 40.

Comment 2 Karolina Surma 2024-06-12 14:55:52 UTC
*** Bug 2291546 has been marked as a duplicate of this bug. ***

Comment 3 Fedora Fails To Install 2024-06-19 19:57:14 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 4 Karolina Surma 2024-09-04 14:30:37 UTC
This package has failed to build with Python 3.13 so far. Fedora 41 is already in the Beta Freeze phase. What's your plan going forward? Will the package be fixed in time for the Final Freeze of Fedora 41 (planned on Oct 15th 2024)?
If you don't plan or can't fix the package before Fedora 41 goes into the Final Freeze phase, please retire the package. You can unretire it anytime during the Fedora 41 lifecycle - doing this now will simply ensure that we don't release Fedora with a broken package. Thank you!

Comment 5 Artur Frenszek-Iwicki 2024-09-04 15:58:06 UTC
This has been confirmed to be caused by a bug in Python 3.13, [0]
and the issue has already been patched. [1]

As such, I see two options:
1. Wait until new Python 3.13 rc, which should fix the issue.
2. Since the package %builds and %installs fine, but fails %check,
   add a patch to temporarily disable the failing test.

[0] https://github.com/python/cpython/issues/123409
[1] https://github.com/python/cpython/pull/123606

Comment 6 Miro Hrončok 2024-09-04 16:01:59 UTC
The next rc should be released this week. So let's wait; if nothing happens by Monday, we can add the patch.

Comment 7 Artur Frenszek-Iwicki 2024-09-09 15:14:32 UTC
*** Bug 2310849 has been marked as a duplicate of this bug. ***

Comment 8 Miro Hrončok 2024-09-09 15:26:38 UTC
Attempting builds with rc2

Comment 9 Artur Frenszek-Iwicki 2024-09-09 15:41:01 UTC
After backporting a few commits from upstream's "dev" branch, the package builds fine with rc2.
I assume that for Rawhide, I should just git push && fedpkg build; but what about F41?

Comment 10 Miro Hrončok 2024-09-09 20:34:11 UTC
My builds have not worked.

Whenever this is pushed to rawhide I can merge to fc41 and build against the new rc2 (I have a side tag set up for that, f41-build-side-95836).

Comment 11 Artur Frenszek-Iwicki 2024-09-09 20:47:23 UTC
Pushed and built for Rawhide.

Comment 12 Fedora Update System 2024-09-10 09:31:48 UTC
FEDORA-2024-b02b8467d2 (jc-1.25.3-4.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-b02b8467d2

Comment 13 Fedora Update System 2024-09-11 02:28:17 UTC
FEDORA-2024-b02b8467d2 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b02b8467d2`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b02b8467d2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Fails To Install 2024-09-11 10:02:12 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 42.

Thanks for taking care of it!

Comment 15 Adam Williamson 2024-09-11 16:36:46 UTC
+3 in https://pagure.io/fedora-qa/blocker-review/issue/1650 , marking accepted FE.

Comment 16 Fedora Update System 2024-09-11 18:21:38 UTC
FEDORA-2024-b02b8467d2 (jc-1.25.3-4.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.