Bug 2247197

Summary: collectd fails to build with Python 3.13: error: implicit declaration of function ‘PyEval_InitThreads’, ‘PySys_SetArgv’
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: collectdAssignee: Ruben Kerkhof <ruben>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 40CC: esandeen, jskarvad, kevin, ksurma, mhlavink, mhroncok, ruben, vstinner
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-09-04 15:41:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2244836    

Description Karolina Surma 2023-10-31 08:28:52 UTC
collectd fails to build with Python 3.13.0a1.

src/python.c: In function ‘cpy_interactive’:
src/python.c:1144:3: error: implicit declaration of function ‘PyEval_InitThreads’; did you mean ‘PyEval_SaveThread’? [-Werror=implicit-function-declaration]
 1144 |   PyEval_InitThreads();
      |   ^~~~~~~~~~~~~~~~~~
      |   PyEval_SaveThread
src/python.c: In function ‘cpy_init_python’:
src/python.c:1308:3: error: implicit declaration of function ‘PySys_SetArgv’ [-Werror=implicit-function-declaration]
 1308 |   PySys_SetArgv(1, &argv);
      |   ^~~~~~~~~~~~~

According to https://docs.python.org/3.13/whatsnew/3.13.html:

- Remove PyEval_InitThreads() and PyEval_ThreadsInitialized() functions, deprecated in Python 3.9.
Since Python 3.7, Py_Initialize() always creates the GIL:
calling PyEval_InitThreads() did nothing and PyEval_ThreadsInitialized() always returned non-zero.
(Contributed by Victor Stinner in https://github.com/python/cpython/issues/105182.)
- Remove the following old functions to configure the Python initialization, deprecated in Python 3.11:
    PySys_AddWarnOptionUnicode(): use PyConfig.warnoptions instead.
    PySys_AddWarnOption(): use PyConfig.warnoptions instead.
    PySys_AddXOption(): use PyConfig.xoptions instead.
    PySys_HasWarnOptions(): use PyConfig.xoptions instead.
    PySys_SetArgvEx(): set PyConfig.argv instead.
    PySys_SetArgv(): set PyConfig.argv instead.
    PySys_SetPath(): set PyConfig.module_search_paths instead.
    Py_SetPath(): set PyConfig.module_search_paths instead.
    Py_SetProgramName(): set PyConfig.program_name instead.
    Py_SetPythonHome(): set PyConfig.home instead.
    Py_SetStandardStreamEncoding(): set PyConfig.stdio_encoding instead, and set also maybe PyConfig.legacy_windows_stdio (on Windows).
    _Py_SetProgramFullPath(): set PyConfig.executable instead.


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06583938-collectd/

For all our attempts to build collectd with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/collectd/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Aoife Moloney 2024-02-15 23:03:07 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle.
Changing version to 40.

Comment 2 Victor Stinner 2024-04-16 11:45:24 UTC
> collectd fails to build with Python 3.13.0a1.

Fedora uses collected version 5.12.0: https://src.fedoraproject.org/rpms/collectd/blob/rawhide/f/collectd.spec

This version was released in September 2020. Since this release, PyEval_InitThreads() is no longer used in the Git repository: https://github.com/collectd/collectd/commit/17d2fbe443b656bb0f74c204eb003cea22f94e60

But there was no release since 2020, only 6.0 *release candidates*: https://github.com/collectd/collectd/releases