Bug 2247570

Summary:	openshift-4: Windows Machine Config Operator unconditionally approves all node CSRs
Product:	[Other] Security Response	Reporter:	Avinash Hanwate <ahanwate>
Component:	vulnerability	Assignee:	Product Security <prodsec-ir-bot>
Status:	NEW ---	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	unspecified	Keywords:	Security
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2247571

Description Avinash Hanwate 2023-11-02 04:06:24 UTC

Windows Machine Config Operator approves CSRs for all nodes trying to join a cluster with WMCO installed. This fails here:
https://github.com/openshift/windows-machine-config-operator/blob/fbe9551005ca0f192c5cbc57e7ab781313dfc827/pkg/csr/csr.go#L84
validateCSRContents can return false without setting an error. This was introduced in
https://github.com/openshift/windows-machine-config-operator/commit/2a00c3129f810cc840b1fd2adcf3e7c6bf303ac9
before this commit, only !valid was checked.

Comment 2 errata-xmlrpc 2024-02-27 15:16:45 UTC

This issue has been addressed in the following products:

  Red Hat OpenShift Container Platform 4.15

Via RHSA-2024:0954 https://access.redhat.com/errata/RHSA-2024:0954