Bug 2247743

Summary:	Ensure provider api server allows empty platform and operator version
Product:	[Red Hat Storage] Red Hat OpenShift Data Foundation	Reporter:	Leela Venkaiah Gangavarapu <lgangava>
Component:	ocs-operator	Assignee:	Leela Venkaiah Gangavarapu <lgangava>
Status:	CLOSED ERRATA	QA Contact:	suchita <sgatfane>
Severity:	unspecified	Docs Contact:
Priority:	medium
Version:	4.14	CC:	ebenahar, muagarwa, odf-bz-bot, resoni
Target Milestone:	---
Target Release:	ODF 4.15.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	isf-provider
Fixed In Version:	4.14.0-162	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-03-19 15:28:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Leela Venkaiah Gangavarapu 2023-11-03 04:20:36 UTC

Description of problem (please be detailed as possible and provide log
snippests):
Ensure provider api server allows empty platform and operator version, this shouldn't stop updating heartbeat timestamp on the storageconsumer CR

Version of all relevant components (if applicable):
4.14.0-160

Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
no

Is there any workaround available to the best of your knowledge?
no

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
1

Can this issue reproducible?
yes

Can this issue reproduce from the UI?


If this is a regression, please provide more details to justify this:


Steps to Reproduce:
1. create a provider and client setup
2. observe job at client operator failing to update heartbeat
3.


Actual results:


Expected results:
heartbeat should be successful even if any other data is erroneous

Additional info:
part of 4.14.z

Comment 3 suchita 2023-11-20 10:38:25 UTC

[provider-client ~]$ oc get storageconsumer -o yaml | grep lastHeartbeat
    lastHeartbeat: "2023-11-20T10:31:01Z"
    lastHeartbeat: "2023-11-20T10:31:01Z"
[provider-client ~]$ date
Mon Nov 20 10:31:35 UTC 2023
[provider-client ~]$ oc get storageconsumer -o yaml | grep lastHeartbeat
    lastHeartbeat: "2023-11-20T10:31:01Z"
    lastHeartbeat: "2023-11-20T10:31:01Z"
[provider-client ~]$ oc get storageconsumer -o yaml | grep lastHeartbeat
    lastHeartbeat: "2023-11-20T10:35:01Z"
    lastHeartbeat: "2023-11-20T10:35:01Z"

The Heartbeat is updating in storage consumer for client

Comment 5 Leela Venkaiah Gangavarapu 2023-11-20 10:49:40 UTC

> Actual expectation is `heartbeat should be successful even if any other data is erroneous`
- my mistake, if the data is erroneous, there should be no update in the timestamp
- you can stop client operator, suspend the job, send something that is not a version via grpcurl
- this is the testing performed if it helps https://github.com/red-hat-storage/ocs-operator/pull/2251#issuecomment-1797679833

Comment 6 suchita 2023-11-21 16:33:16 UTC

Verified  the bug for negative erroneous scenarios and Heartbeat updated or not updated as expected:
1: invalid parameter error data (invalid version '12.1.z'): heartbeat is not got updated. As a resultant alert is observed.
2. correction in version parameter enables the heartbeat
3. old version value in the version field (4.10.1) : updating the heartbeat (However an alert was observed - the version is older than more than 1 minor version)

Comment 10 errata-xmlrpc 2024-03-19 15:28:20 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.15.0 security, enhancement, & bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:1383