Bug 2247955

Summary:	Review Request: rust-cvt - Expose the cvt function from Rust libstd
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Seth Maurice-Brant <fedoraproject.kwudj>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	fedoraproject.kwudj, package-review
Target Milestone:	---	Flags:	fedoraproject.kwudj: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rust-cvt-0.1.2-1.fc40	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-11-08 15:36:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Fabio Valentini 2023-11-05 00:27:07 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-cvt.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-cvt-0.1.2-1.fc39.src.rpm

Description:
Expose the cvt function from Rust libstd.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-11-05 00:27:10 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=108592635

Comment 2 Fedora Review Service 2023-11-05 03:16:11 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6599197
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2247955-rust-cvt/srpm-builds/06599197/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Seth Maurice-Brant 2023-11-08 14:36:44 UTC

This is a very simple package built with rust2rpm, which greatly simplifies the packaging and review process.

- Everything builds OK
- Licenses are present
- Naming is all good etc

I cannot see any issues with this, so I will go ahead and mark this as ACCEPTED right now.

Comment 4 Fabio Valentini 2023-11-08 15:07:11 UTC

Thanks for the review!

Comment 5 Fedora Admin user for bugzilla script actions 2023-11-08 15:07:36 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cvt

Comment 6 Fabio Valentini 2023-11-08 15:36:06 UTC

Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-6a7155a8c4