Bug 2248907
| Summary: | Review Request: ffmpeg4 - compat version of ffmpeg | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yaakov Selkowitz <yselkowi> | ||||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||||
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | kwizart, ngompa13, package-review | ||||||
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review?
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://ffmpeg.org/ | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2023-11-30 05:25:01 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 2218117 | ||||||||
| Attachments: |
|
||||||||
|
Description
Yaakov Selkowitz
2023-11-09 16:14:59 UTC
The biggest thing that needs to be looked at here is the upgrade path from RPMFusion compat-ffmpeg4. Copr build: https://copr.fedorainfracloud.org/coprs/build/6616547 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2248907-ffmpeg4/fedora-rawhide-x86_64/06616547-ffmpeg4/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://yselkowitz.fedorapeople.org/ffmpeg4.spec SRPM URL: https://yselkowitz.fedorapeople.org/ffmpeg4-4.4.4-1.fc40.src.rpm Description: FFmpeg is a leading multimedia framework, able to decode, encode, transcode, mux, demux, stream, filter and play pretty much anything that humans and machines have created. It supports the most obscure ancient formats up to the cutting edge. No matter if they were designed by some standards committee, the community or a corporation. This version is intended only for dependent packages which have yet to be ported to the latest API provided by the ffmpeg package. Fedora Account System Username: yselkowitz Created attachment 1998158 [details]
The .spec file difference from Copr build 6616547 to 6616678
Copr build: https://copr.fedorainfracloud.org/coprs/build/6616678 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2248907-ffmpeg4/fedora-rawhide-x86_64/06616678-ffmpeg4/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://yselkowitz.fedorapeople.org/ffmpeg4.spec SRPM URL: https://yselkowitz.fedorapeople.org/ffmpeg4-4.4.4-3.fc40.src.rpm Description: FFmpeg is a leading multimedia framework, able to decode, encode, transcode, mux, demux, stream, filter and play pretty much anything that humans and machines have created. It supports the most obscure ancient formats up to the cutting edge. No matter if they were designed by some standards committee, the community or a corporation. This version is intended only for dependent packages which have yet to be ported to the latest API provided by the ffmpeg package. Fedora Account System Username: yselkowitz Created attachment 1998185 [details]
The .spec file difference from Copr build 6616678 to 6617016
Copr build: https://copr.fedorainfracloud.org/coprs/build/6617016 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2248907-ffmpeg4/fedora-rawhide-x86_64/06617016-ffmpeg4/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this review. Please drop obsoletes/provides from compat-ffmpeg4{,-devel} it's uneeded:
- Fedora build will have access to only this package version in order to build any neeed deps.
- End-users having a fuller ffmpeg4 can keep it without issue.
If ever a complementary package (modeled after ffmpeg-free and libavcodec-freeworld), I'm expecting the maintainers of such ffmpeg4 package to provide the needed patch and coordinate for counterpart updates as appropriates.
Now I see little point to have this package, likely to build vlc-free:
- This will have h264/5 vaapi hwdec disabled and eventually vp9 kept (but av1 is anachronistic with ffmpeg4, I guess).
- The very much point of ffmpeg4 with vlc was to build vaapi hwdec.
- With ffmpeg4 hwdec disabled to this point, best is to use main ffmpeg with vlc.
To prevent any future issue, please consider using
vlc as -free sub-package suffix to prevent conflict with our previously existing build.
vlc 3.0.20 does compile with ffmpeg 6.0.1, and other distros are shipping like too, so we'll go with that. Please remember that a ffmpeg-6.1 is due in rawhide. |